diff for duplicates of <530600E9.4010506@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 9fbe636..0b3f4c9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ Il 20/02/2014 14:18, walter harms ha scritto: >> /* when no next entry is found, the current entry[i] is reselected */ >> - for (j = i + 1; ; j = (j + 1) % nent) { >> - struct kvm_cpuid_entry2 *ej = &vcpu->arch.cpuid_entries[j]; ->> - if (ej->function = e->function) { +>> - if (ej->function == e->function) { >> - ej->flags |= KVM_CPUID_FLAG_STATE_READ_NEXT; >> - return j; >> - } @@ -55,9 +55,9 @@ Il 20/02/2014 14:18, walter harms ha scritto: > > Is there any guaranty that this will not loop forever ? > -> an if (i=j) return 0; would be on the save side. (I guess that +> an if (i==j) return 0; would be on the save side. (I guess that > these was the idea behind the for). -Once i=j you'll get ej->function = e->function and exit. +Once i==j you'll get ej->function == e->function and exit. Paolo diff --git a/a/content_digest b/N1/content_digest index 97f6446..4d2295a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\05306009D.8040205@bfs.de\0" "From\0Paolo Bonzini <pbonzini@redhat.com>\0" "Subject\0Re: [patch RFC] kvm, cpuid: silence a buffer overflow warning\0" - "Date\0Thu, 20 Feb 2014 13:19:37 +0000\0" + "Date\0Thu, 20 Feb 2014 14:19:37 +0100\0" "To\0wharms@bfs.de\0" "Cc\0Dan Carpenter <dan.carpenter@oracle.com>" Gleb Natapov <gleb@kernel.org> @@ -50,7 +50,7 @@ ">> \t/* when no next entry is found, the current entry[i] is reselected */\n" ">> -\tfor (j = i + 1; ; j = (j + 1) % nent) {\n" ">> -\t\tstruct kvm_cpuid_entry2 *ej = &vcpu->arch.cpuid_entries[j];\n" - ">> -\t\tif (ej->function = e->function) {\n" + ">> -\t\tif (ej->function == e->function) {\n" ">> -\t\t\tej->flags |= KVM_CPUID_FLAG_STATE_READ_NEXT;\n" ">> -\t\t\treturn j;\n" ">> -\t\t}\n" @@ -72,11 +72,11 @@ ">\n" "> Is there any guaranty that this will not loop forever ?\n" ">\n" - "> an if (i=j) return 0; would be on the save side. (I guess that\n" + "> an if (i==j) return 0; would be on the save side. (I guess that\n" "> these was the idea behind the for).\n" "\n" - "Once i=j you'll get ej->function = e->function and exit.\n" + "Once i==j you'll get ej->function == e->function and exit.\n" "\n" Paolo -a1fbd70905c7f60886e1022c97679c26ef2095a4fe8ebf70cf06230b1f26ccdc +9c6891fa3a8ae949c9f11fbbeb2fa28166cee71e460c67ab558733588a3defe9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.