From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGUEJ-0003g9-Kp for qemu-devel@nongnu.org; Thu, 20 Feb 2014 09:04:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGUED-0007VH-6G for qemu-devel@nongnu.org; Thu, 20 Feb 2014 09:03:59 -0500 Received: from mail-pd0-f176.google.com ([209.85.192.176]:38325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGUEC-0007V0-Uy for qemu-devel@nongnu.org; Thu, 20 Feb 2014 09:03:53 -0500 Received: by mail-pd0-f176.google.com with SMTP id w10so1843671pde.7 for ; Thu, 20 Feb 2014 06:03:52 -0800 (PST) Message-ID: <53060B40.9010903@ozlabs.ru> Date: Fri, 21 Feb 2014 01:03:44 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru> <1392904246-15575-2-git-send-email-aik@ozlabs.ru> <5306094B.4010608@redhat.com> In-Reply-To: <5306094B.4010608@redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/6] boot: extend get_boot_devices_list() to ignore suffixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alexander Graf , Andreas Faerber On 02/21/2014 12:55 AM, Paolo Bonzini wrote: > Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: >> As suffixes do not make sense for sPAPR's device tree and >> there is no way to filter them out on the BusState::get_fw_dev_path >> level, let's add an ability for the external caller to specify >> whether to apply suffixes or not. >> >> We could handle suffixes in SLOF (ignore for now) but this would require >> serious rework in the node opening code in SLOF which has no obvious >> benefit for the currently emulated sPAPR machine. > > For the record, the commit message is not entirely correct in presenting > the situation. QEMU *does not care in any way* of benefits for the > currently emulated sPAPR machine. The benefit would be to QEMU in having > simpler code. > > You just got a wildcard because Forth is scary. :) I know :) Should I remove that part and replace it with the "scary" one? > Paolo > >> Signed-off-by: Alexey Kardashevskiy >> --- >> Changes: >> v4: >> * changed commit message about not having plans in SLOF rework as it is >> scary :) > > -- Alexey