Re: [Qemu-devel] [PATCH v2 4/6] qemu-img amend: Support multiple -o options

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On 02/20/2014 07:57 AM, Kevin Wolf wrote:
> Instead of ignoring all option values but the last one, multiple -o
> options now have the same meaning as having a single option with all
> settings in the order of their respective -o options.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qemu-img.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Same comment as in 2/6 about the surprise of a trailing comma empty
option turning into a literal comma.

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qemu-img.c b/qemu-img.c
> index ba6e82d..d6dc7ec 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -2658,7 +2658,13 @@ static int img_amend(int argc, char **argv)
>                  help();
>                  break;

Noticed this in context - this break is dead code, since help() never
returns.  (And remind me again WHY help has to return with non-zero
status, even when explicitly requested?)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]