From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC for-4.5 5/5] xen/arm: Remove asm-arm/processor-ca{15, 7}.h headers Date: Thu, 20 Feb 2014 16:49:41 +0000 Message-ID: <53063225.2020200@linaro.org> References: <1392149085-14366-1-git-send-email-julien.grall@linaro.org> <1392149085-14366-6-git-send-email-julien.grall@linaro.org> <1392812393.29739.32.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WGWoj-0005W2-Iw for xen-devel@lists.xenproject.org; Thu, 20 Feb 2014 16:49:45 +0000 Received: by mail-ea0-f176.google.com with SMTP id b10so1027136eae.21 for ; Thu, 20 Feb 2014 08:49:44 -0800 (PST) In-Reply-To: <1392812393.29739.32.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 02/19/2014 12:19 PM, Ian Campbell wrote: > On Tue, 2014-02-11 at 20:04 +0000, Julien Grall wrote: >> Theses headers are not in the right directory and are not used anymore. >> >> Signed-off-by: Julien Grall > > Acked-by: Ian Campbell > > Although perhaps proc-v7-c.c ought to be using some of these? e.g. > ACTLR_CA15_SMP instead of ACTLR_V7_SMP, which now looks to be badly > named to me... The name ACTLR_CA15_SMP gives the impression that it's only for Cortex A15, rather than A7. ACTLR_CORTEX_SMP is not better because we may have other cortex in future that do not have the SMP bit in the future. What about hardcoding the bit, as it will be only use here? Cheers, -- Julien Grall