From: Paolo Bonzini <pbonzini@redhat.com>
To: Roland Dreier <roland@purestorage.com>
Cc: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h
Date: Thu, 20 Feb 2014 18:15:43 +0100 [thread overview]
Message-ID: <5306383F.6060109@redhat.com> (raw)
In-Reply-To: <CAL1RGDUMW5K92J+TGaidjetCqNQwEPXE21LAvaSRgOgVPJQu+w@mail.gmail.com>
Il 20/02/2014 18:14, Roland Dreier ha scritto:
>> > Looks like _ is more common than - for device properties:
>> >
>> > $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l
>> > 132
>> > $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l
>> > 77
> And more locally, "scsi-id" in scsi-bus.c is the only property in
> hw/scsi with a '-'. scsi-disk.c already has "max_unmap_size" and
> megasas.c has several '_' already.
>
> With that said I'm fine either way, and if you want to munge my patch
> to use '-' that's perfectly OK with me. Or I'm happy to resubmit in
> the other form.
No, your patch is fine. We'll sort out what to do with underscores and
dashes, looks like there is a plan...
Thanks for your contribution to QEMU!
Paolo
next prev parent reply other threads:[~2014-02-20 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 17:14 [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h Roland Dreier
2014-02-20 17:15 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-19 16:28 Roland Dreier
2014-02-19 17:07 ` Paolo Bonzini
2014-02-19 18:11 ` Andreas Färber
2014-02-19 18:18 ` Roland Dreier
2014-02-19 22:09 ` Paolo Bonzini
2014-02-20 15:35 ` Paolo Bonzini
2014-02-20 16:02 ` Andreas Färber
2014-02-20 16:10 ` Paolo Bonzini
2014-02-20 17:54 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306383F.6060109@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.