From: Casey Leedom <leedom@chelsio.com>
To: Steve Wise <swise@opengridcomputing.com>,
Hariprasad Shenai <hariprasad@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dm@chelsio.com,
nirranjan@chelsio.com, kumaras@chelsio.com, santosh@chelsio.com
Subject: Re: [PATCH net-next 1/8] cxgb4: Add support to recognize 40G links
Date: Thu, 20 Feb 2014 10:07:21 -0800 [thread overview]
Message-ID: <53064459.3030106@chelsio.com> (raw)
In-Reply-To: <53051E48.9050901@opengridcomputing.com>
On 02/19/14 13:12, Steve Wise wrote:
>
> You probably should add SPEED_40000 to include/uapi/linux/ethtool.h as
> part of this series.
I'm ~pretty sure~ that the "word on the street" was that the
community wanted to get away from the SPEED_XXX symbols since they
simply represented the values XXX. Thus they didn't offer any real
symbolic isolation from weird constants, etc. I believe that the old
SPEED_XXX values were left in place in order to avoid making tons of
changes everywhere ...
Casey
next prev parent reply other threads:[~2014-02-20 18:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 12:26 [PATCH net-next 0/8] Adds support for Chelsio T5 40G adapter and Misc. fixes Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 1/8] cxgb4: Add support to recognize 40G links Hariprasad Shenai
2014-02-19 21:12 ` Steve Wise
2014-02-20 18:07 ` Casey Leedom [this message]
2014-02-20 19:00 ` Florian Fainelli
2014-02-20 19:16 ` Casey Leedom
2014-02-21 4:37 ` Kumar Sanghvi
2014-02-21 18:49 ` Casey Leedom
2014-02-22 23:59 ` Ben Hutchings
2014-02-18 12:26 ` [PATCH net-next 2/8] cxgb4: Print adapter VPD Part Number instead of Engineering Change field Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 3/8] cxgb4: Allow >10G ports to have multiple queues Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 4/8] cxgb4: LE-Workaround is not atomic in firmware Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 5/8] cxgb4: Query firmware for T5 ULPTX MEMWRITE DSGL capabilities Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 6/8] cxgb4: Remove unused registers and add missing ones Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 7/8] cxgb4: Don't assume LSO only uses SGL path in t4_eth_xmit() Hariprasad Shenai
2014-02-18 12:26 ` [PATCH net-next 8/8] cxgb4: Add more PCI device ids Hariprasad Shenai
2014-02-18 21:24 ` [PATCH net-next 0/8] Adds support for Chelsio T5 40G adapter and Misc. fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53064459.3030106@chelsio.com \
--to=leedom@chelsio.com \
--cc=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=santosh@chelsio.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.