From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32)
Date: Thu, 20 Feb 2014 22:18:54 +0100 [thread overview]
Message-ID: <5306713E.2040508@weilnetz.de> (raw)
In-Reply-To: <1392918631-14234-1-git-send-email-peter.maydell@linaro.org>
Am 20.02.2014 18:50, schrieb Peter Maydell:
> Win32 doesn't have a cpuid.h, and MacOSX may have one but without
> the __cpuid() function we use, which means that commit 9d2eec20
> broke the build for those platforms. Fix this by tightening up
> our configure cpuid.h check to test that the functions we need
> are present, and adding some missing #ifdef guerds in
> tcg/i386/tcg-target.c.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Tested with Linux x86/64 gcc build, Linux x86/64 clang build,
> W32 cross-build and MacOSX 10.8 build. If somebody would like to
> review this I'll apply it directly to unbreak things.
> Apologies for not catching it before I pushed the tcg pullreq;
> I had forgotten to add the 'build on w32' command to my script.
>
MinGW-w64's gcc has cpuid.h, so my 32 and 64 bit cross builds work
without problems. We can use that code for MinGW, too, but we could also
stop supporting MinGW (which has several other deficits).
Regards
Stefan
next prev parent reply other threads:[~2014-02-20 21:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 17:50 [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32) Peter Maydell
2014-02-20 17:53 ` Peter Maydell
2014-02-20 19:22 ` Richard Henderson
2014-02-20 21:18 ` Stefan Weil [this message]
2014-02-20 22:18 ` Peter Maydell
2014-02-21 5:53 ` Stefan Weil
2014-02-21 16:32 ` Peter Maydell
2014-02-20 23:55 ` Brad Smith
2014-02-21 0:09 ` Peter Maydell
2014-02-21 0:48 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5306713E.2040508@weilnetz.de \
--to=sw@weilnetz.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.