From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WGb1S-0006Zg-Ue
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:19:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WGb1N-0006e1-4c
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:19:10 -0500
Received: from smtp.mail.uni-mannheim.de ([134.155.96.80]:47374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WGb1M-0006by-Ur
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:19:05 -0500
Message-ID: <5306713E.2040508@weilnetz.de>
Date: Thu, 20 Feb 2014 22:18:54 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1392918631-14234-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1392918631-14234-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without
 working cpuid.h (MacOSX, Win32)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Richard Henderson <rth@twiddle.net>

Am 20.02.2014 18:50, schrieb Peter Maydell:
> Win32 doesn't have a cpuid.h, and MacOSX may have one but without
> the __cpuid() function we use, which means that commit 9d2eec20
> broke the build for those platforms. Fix this by tightening up
> our configure cpuid.h check to test that the functions we need
> are present, and adding some missing #ifdef guerds in
> tcg/i386/tcg-target.c.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Tested with Linux x86/64 gcc build, Linux x86/64 clang build,
> W32 cross-build and MacOSX 10.8 build. If somebody would like to
> review this I'll apply it directly to unbreak things.
> Apologies for not catching it before I pushed the tcg pullreq;
> I had forgotten to add the 'build on w32' command to my script.
> 


MinGW-w64's gcc has cpuid.h, so my 32 and 64 bit cross builds work
without problems. We can use that code for MinGW, too, but we could also
stop supporting MinGW (which has several other deficits).

Regards
Stefan