From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGbNN-0005ac-Kl for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:41:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGbNI-0005hT-EB for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:41:49 -0500 Received: from smtp.mail.uni-mannheim.de ([134.155.96.80]:42913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGbNI-0005hO-7a for qemu-devel@nongnu.org; Thu, 20 Feb 2014 16:41:44 -0500 Message-ID: <53067693.6030304@weilnetz.de> Date: Thu, 20 Feb 2014 22:41:39 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1392925465-14498-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1392925465-14498-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] trace: Fix build warnings for Win32 build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , patches@linaro.org Am 20.02.2014 20:44, schrieb Peter Maydell: > The Win32 build warns about trace/control-internal.h: > > warning: 'trace_event_count' declared inline after being called > > Fix this by simply reordering trace_event_id() and > trace_event_count(). > > Signed-off-by: Peter Maydell > --- > trace/control-internal.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Stefan Weil This is not OS specific, but depends on the compiler. MinGW-w64 uses a newer gcc which does not complain. Reordering the two function is reasonable nevertheless. Regards Stefan