From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGdT0-0001Sx-Lg for qemu-devel@nongnu.org; Thu, 20 Feb 2014 18:55:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGdSy-0005AR-Vv for qemu-devel@nongnu.org; Thu, 20 Feb 2014 18:55:46 -0500 Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:3252 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGdSy-000590-Re for qemu-devel@nongnu.org; Thu, 20 Feb 2014 18:55:44 -0500 Message-ID: <530695F7.8080406@comstyle.com> Date: Thu, 20 Feb 2014 18:55:35 -0500 From: Brad Smith MIME-Version: 1.0 References: <1392918631-14234-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1392918631-14234-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org, Richard Henderson On 20/02/14 12:50 PM, Peter Maydell wrote: > Win32 doesn't have a cpuid.h, and MacOSX may have one but without > the __cpuid() function we use, which means that commit 9d2eec20 > broke the build for those platforms. Fix this by tightening up > our configure cpuid.h check to test that the functions we need > are present, and adding some missing #ifdef guerds in > tcg/i386/tcg-target.c. The build will also fail if not using fairly new GCC or LLVM/Clang 3.4 or newer. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.