From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WGioE-0000Qm-HO
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 00:38:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WGio8-0004hM-GP
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 00:38:02 -0500
Received: from smtp.mail.uni-mannheim.de ([134.155.96.80]:59841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WGio8-0004gt-9x
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 00:37:56 -0500
Message-ID: <5306E631.4090108@weilnetz.de>
Date: Fri, 21 Feb 2014 06:37:53 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1392925525-14574-1-git-send-email-peter.maydell@linaro.org>
	<530672F1.4070104@weilnetz.de>
	<CAFEAcA9Ty8AFUvMDAr9EjJSEXwMaHjq3_Xe0DUVEy0ZOWVdQqw@mail.gmail.com>
In-Reply-To: <CAFEAcA9Ty8AFUvMDAr9EjJSEXwMaHjq3_Xe0DUVEy0ZOWVdQqw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/arm/spitz: Avoid clash with Windows
 header symbol MOD_SHIFT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Patch Tracking <patches@linaro.org>

Am 20.02.2014 23:22, schrieb Peter Maydell:
> On 20 February 2014 21:26, Stefan Weil <sw@weilnetz.de> wrote:
>> There was a suggestion to remove some dependencies on windows.h (which
>> causes the trouble here). I recently started doing this, and that
>> approach fixes the warning, too. Maybe I can send a patch next weekend.
> 
> That would probably be the nicest approach, yes. I won't apply
> this to the target-arm queue just yet.
> 
> I'm wondering if we might be able to get to the point of enabling
> -Werror for Windows and MacOSX builds. Do you think that would
> be a useful thing to do? (Obviously for git builds only, same as Linux.)

Yes, I think so. With MinGW-w64 this is quite realistic, even when I add
-Wextra (which I also use for my Linux builds). Some less important
warnings must be suppressed then, of course.

> (For MacOSX there are some deprecation warnings in the audio
> code I need to fix first but we otherwise compile pretty much
> warning free on 10.8. I'd be reliant on reports from other people
> for warnings on 10.9 and on earlier-than-10.8, though.)

10.9 also shows the audio deprecation warnings, but that's all as far as
I remember.

Stefan