From: David Vrabel <david.vrabel@citrix.com>
To: Andrew Bennieston <andrew.bennieston@citrix.com>
Cc: Paul Durrant <Paul.Durrant@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH V4 net-next 2/5] xen-netback: Add support for multiple queues
Date: Fri, 21 Feb 2014 12:22:40 +0000 [thread overview]
Message-ID: <53074510.2040408@citrix.com> (raw)
In-Reply-To: <53074490.8030806@citrix.com>
>>> + char *xspath = NULL;
>>
>> I don't think you need the NULL init here. xspath is set in both
>> branches of the if statement below.
>
> Indeed, but I prefer to initialise things sanely where possible. It
> makes it easier to spot problems with later modifications of the code,
> e.g. if one of those branches changed.
Kernel style (but probably not documented anywhere) is to only
initialize locals were necessary.
David
next prev parent reply other threads:[~2014-02-21 12:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 17:57 [PATCH V4 net-next 0/5] xen-net{back, front}: Multiple transmit and receive queues Andrew J. Bennieston
2014-02-17 17:57 ` Andrew J. Bennieston
2014-02-17 17:57 ` [PATCH V4 net-next 1/5] xen-netback: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-02-17 17:57 ` Andrew J. Bennieston
2014-02-21 12:08 ` Paul Durrant
2014-02-21 12:08 ` Paul Durrant
2014-02-21 12:22 ` Andrew Bennieston
2014-02-21 12:22 ` Andrew Bennieston
2014-02-21 12:24 ` Paul Durrant
2014-02-21 12:24 ` Paul Durrant
2014-02-17 17:57 ` [PATCH V4 net-next 2/5] xen-netback: Add support for multiple queues Andrew J. Bennieston
2014-02-17 17:57 ` Andrew J. Bennieston
2014-02-21 12:13 ` Paul Durrant
2014-02-21 12:20 ` Andrew Bennieston
2014-02-21 12:22 ` David Vrabel [this message]
2014-02-21 12:24 ` Andrew Bennieston
2014-02-21 12:24 ` Andrew Bennieston
2014-02-21 12:22 ` David Vrabel
2014-02-21 13:16 ` David Laight
2014-02-21 13:16 ` David Laight
2014-02-21 12:20 ` Andrew Bennieston
2014-02-21 12:13 ` Paul Durrant
2014-02-17 17:57 ` [PATCH V4 net-next 3/5] xen-netfront: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-02-17 17:57 ` Andrew J. Bennieston
2014-02-17 18:04 ` David Vrabel
2014-02-17 18:04 ` David Vrabel
2014-02-17 17:57 ` [PATCH V4 net-next 4/5] xen-netfront: Add support for multiple queues Andrew J. Bennieston
2014-02-17 17:57 ` Andrew J. Bennieston
2014-02-17 18:04 ` David Vrabel
2014-02-17 18:04 ` David Vrabel
2014-02-17 17:58 ` [PATCH V4 net-next 5/5] xen-net{back, front}: Document multi-queue feature in netif.h Andrew J. Bennieston
2014-02-17 17:58 ` Andrew J. Bennieston
2014-02-17 18:06 ` David Vrabel
2014-02-17 18:06 ` [PATCH V4 net-next 5/5] xen-net{back,front}: " David Vrabel
2014-02-21 12:22 ` Paul Durrant
2014-02-21 12:24 ` Andrew Bennieston
2014-02-21 12:24 ` [PATCH V4 net-next 5/5] xen-net{back, front}: " Andrew Bennieston
2014-02-21 12:22 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53074510.2040408@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=andrew.bennieston@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.