From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGwng-00082N-Bd for qemu-devel@nongnu.org; Fri, 21 Feb 2014 15:34:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGwnb-0002Y8-9R for qemu-devel@nongnu.org; Fri, 21 Feb 2014 15:34:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGwna-0002WH-Uc for qemu-devel@nongnu.org; Fri, 21 Feb 2014 15:34:19 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1LKYIJ6029001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Feb 2014 15:34:18 -0500 Message-ID: <5307B849.9030102@redhat.com> Date: Fri, 21 Feb 2014 13:34:17 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393013113-25367-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1393013113-25367-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tT1wKJW3DFDia4tleBHjJWldvsqmDgIVJ" Subject: Re: [Qemu-devel] [PATCH v2] check-qdict: Test termination of qdict_array_split() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tT1wKJW3DFDia4tleBHjJWldvsqmDgIVJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/21/2014 01:05 PM, Max Reitz wrote: > qdict_array_split() should terminate if it encounters both an entry wit= h > a key of "%u" and entries with keys prefixed "%u." for the same index. >=20 > This patch adds a test for this case. >=20 > Signed-off-by: Max Reitz > --- > This is a followup to my "Extract non-QDicts in qdict_array_split()" se= ries. >=20 > + /* > + * Test the split of > + * > + * { > + * "0": 42, > + * "1": 23, > + * "1.x": 84 > + * } For good measure, I might have included a "2":..., which also does not get split out (proving that we didn't just skip over 1 and go on to 2, but actually stopped). But at this point, I think you've covered the code, so I won't insist. Thanks for the extra test: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tT1wKJW3DFDia4tleBHjJWldvsqmDgIVJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTB7hJAAoJEKeha0olJ0Nq0D4H/1VLM6rUE+bKK8ywP/Mo4RaM sp+wcXYUXsVp3F0FniH8p8rJUEvaZME5LybYMYW5paSRlHHSpgZAl2qo93QrZ+Xw 5veJXdBZ8d2j5Il2Qqob4Xe6FRDCju7D65J4QFi9GmqgHsVkmix7kxq0NyuZYfZP 441mvtpGuM5xU8ID/5CvvQNNl+syPNJUt6ZGTII8wYncJP1qzDcYNLxElvNgbugW 20oBdCy6OvxOigI/5budQlCXYmLbsiOjy7FCQw5XFzOQqxu+AnKlsktGWpen2XWS yQmr/z4+DiKzcKS2c1JZItQwi4fF4TNNJEzppUmJ7WreXD2bSq7be4B5yWB1zg8= =DSKu -----END PGP SIGNATURE----- --tT1wKJW3DFDia4tleBHjJWldvsqmDgIVJ--