From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
<x86@kernel.org>, <dougthompson@xmission.com>,
<bhelgaas@google.com>, <JBeulich@suse.com>,
<dan.carpenter@oracle.com>, <linux-kernel@vger.kernel.org>,
<linux-edac@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<Arindam.Nath@amd.com>
Subject: Re: [PATCH] amd64_edac: Add support for newer F16h models
Date: Fri, 21 Feb 2014 15:04:47 -0600 [thread overview]
Message-ID: <5307BF6F.8040303@amd.com> (raw)
In-Reply-To: <20140221142749.GC11531@pd.tnic>
On 2/21/2014 8:27 AM, Borislav Petkov wrote:
> On Thu, Feb 20, 2014 at 10:28:46AM -0600, Aravind Gopalakrishnan wrote:
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 97fbecd..e91ad27 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -528,6 +528,8 @@
>> #define PCI_DEVICE_ID_AMD_15H_NB_F5 0x1605
>> #define PCI_DEVICE_ID_AMD_16H_NB_F3 0x1533
>> #define PCI_DEVICE_ID_AMD_16H_NB_F4 0x1534
>> +#define PCI_DEVICE_ID_AMD_16H_M30H_NB_F3 0x1583
>> +#define PCI_DEVICE_ID_AMD_16H_M30H_NB_F4 0x1584
> Just put those in arch/x86/include/asm/amd_nb.h as amd64_edac.c includes
> it already and you can avoid the pci_ids.h addition. Unless there are
> plans to use F{3,4} in other places too...
>
F{3,4} are used by hwmon/k10temp.c and hwmon/fam15h_power.c and they
will need definitions to be places here in pci_ids.h
But I'm not sure if the hwmon drivers need to carry support for this
model yet (will verify that)
If not, I'll remove them and resend.
Thanks,
-Aravind.
next prev parent reply other threads:[~2014-02-21 21:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 16:28 [PATCH] amd64_edac: Add support for newer F16h models Aravind Gopalakrishnan
2014-02-21 14:27 ` Borislav Petkov
2014-02-21 21:04 ` Aravind Gopalakrishnan [this message]
2014-02-24 14:09 ` Borislav Petkov
2014-02-27 16:22 ` Aravind Gopalakrishnan
2014-02-27 16:31 ` Borislav Petkov
2014-02-27 16:32 ` Aravind Gopalakrishnan
2014-02-27 16:31 ` Borislav Petkov
2014-02-27 17:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5307BF6F.8040303@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=Arindam.Nath@amd.com \
--cc=JBeulich@suse.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=dougthompson@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.