All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	Jianguo Wu <wujianguo@huawei.com>, Andy Honig <ahonig@google.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] x86, kaslr: randomize module base load address
Date: Fri, 21 Feb 2014 13:18:26 -0800	[thread overview]
Message-ID: <5307C2A2.5010006@zytor.com> (raw)
In-Reply-To: <20140221131531.2db80023c59895a930cf374f@linux-foundation.org>

On 02/21/2014 01:15 PM, Andrew Morton wrote:
>>
>> I've been slapped down for adding more config options in the past, and
>> I think it's unlikely that people using CONFIG_RANDOMIZE_BASE won't
>> want the modules base randomized too. I think this is a safe default,
>> but if you see it as a requirement, I can change it.
> 
> I think there were issues with some embedded systems where it's
> hard/impossible to provide/alter boot parameters.
> 

We now allow kernel parameters to be compiled into the kernel image for
that reason.

> 
> btw, would it be better to make each module have its own offset rather
> than using the same offset for all of them?  That could cause problems
> with vmap space fragmentation I guess.
> 

... but it would improve the amount of entropy.

	-hpa


  reply	other threads:[~2014-02-21 21:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 20:21 [PATCH] x86, kaslr: randomize module base load address Kees Cook
2014-02-21 20:36 ` Andrew Morton
2014-02-21 21:05   ` Kees Cook
2014-02-21 21:09     ` H. Peter Anvin
2014-02-21 21:15     ` Andrew Morton
2014-02-21 21:18       ` H. Peter Anvin [this message]
2014-02-21 21:27         ` Andrew Morton
2014-02-21 23:01           ` H. Peter Anvin
2014-02-21 21:21       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5307C2A2.5010006@zytor.com \
    --to=hpa@zytor.com \
    --cc=ahonig@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=wujianguo@huawei.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.