Re: [Qemu-devel] [PATCH V19 11/12] quorum: Add quorum_open() and quorum_close().

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

On 02/21/2014 02:21 PM, Benoît Canet wrote:
> From: Benoît Canet <benoit@irqsave.net>
> 
> Example of command line:
> 
> -drive if=virtio,driver=quorum,\
> children.0.file.filename=1.raw,\
> children.0.node-name=1.raw,\
> children.0.driver=raw,\
> children.1.file.filename=2.raw,\
> children.1.node-name=2.raw,\
> children.1.driver=raw,\
> children.2.file.filename=3.raw,\
> children.2.node-name=3.raw,\
> children.2.driver=raw,\
> vote-threshold=2
> 

> +++ b/qapi-schema.json
> @@ -4432,6 +4432,24 @@
>              'raw': 'BlockdevRef' } }
>  
>  ##
> +# @BlockdevOptionsQuorum
> +#
> +# Driver specific block device options for Quorum
> +#
> +# @blkverify:      #optional true if the driver must print content mismatch
> +#

I might have mentioned it defaults to false.

> +# @children:       the children block device to use

s/device/devices/

> +#
> +# @vote_threshold: the vote limit under which a read will fail

s/_/-/ to match the schema below

> +#
> +# Since: 2.0
> +##
> +{ 'type': 'BlockdevOptionsQuorum',
> +  'data': { '*blkverify': 'bool',
> +            'children': [ 'BlockdevRef' ],
> +            'vote-threshold': 'int' } }

As this series is already queued, we may need a followup patch to fix
these nits.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]