From mboxrd@z Thu Jan 1 00:00:00 1970 From: Milan Broz Subject: Re: dm-crypt: remove per-cpu structure Date: Sat, 22 Feb 2014 19:58:04 +0100 Message-ID: <5308F33C.5080405@gmail.com> References: <20140220235935.GA32743@redhat.com> <20140221023240.GA338@redhat.com> <53087BD3.1000900@gmail.com> <20140222142526.GA12207@redhat.com> <5308DF91.6030003@gmail.com> <20140222182907.GA13445@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140222182907.GA13445@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mike Snitzer Cc: Tejun Heo , Mikulas Patocka , device-mapper development , Lisa Du , "Alasdair G. Kergon" List-Id: dm-devel.ids On 02/22/2014 07:29 PM, Mike Snitzer wrote: > Thanks for the configuration scenarios. I think I've asked this of you > before but: Do you have any automated testing? Something that we hand a > blockdevice to and it produces a result that you find meaningful to use > as a point of comparison. Ask Ondra, he should have all code what I used (I think he modified it later). (It was some fio scripts, stacked dmcrypt test, some basic dt and fsx tests and some simple seek test.) I run it against several versions (no patch, without sort part, etc) and tried to compare times and throughput. It is of course possible I did some stupid mistake. On top of it, I do not have anything better. And I do not have any suitable hw for testing now, so I can just say my opinion. I just hope you have more facts than you mentioned here to support your decision to merge these changes. Milan