From: Guenter Roeck <linux@roeck-us.net>
To: Wim Van Sebroeck <wim@iguana.be>, Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 10/11] watchdog: xilinx: Enable this driver for Zynq
Date: Sat, 22 Feb 2014 12:42:23 -0800 [thread overview]
Message-ID: <53090BAF.3080806@roeck-us.net> (raw)
In-Reply-To: <20140222184419.GA21504@spo001.leaseweb.com>
On 02/22/2014 10:44 AM, Wim Van Sebroeck wrote:
> Hi Michal,
>
>> Enable this driver for Zynq.
>> Move it to architecture independent Kconfig part.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>> Build tested by zero day testing system.
>> ---
>> drivers/watchdog/Kconfig | 22 +++++++++-------------
>> 1 file changed, 9 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index 9db5d3c..6120403 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -111,6 +111,15 @@ config WM8350_WATCHDOG
>> Support for the watchdog in the WM8350 AudioPlus PMIC. When
>> the watchdog triggers the system will be reset.
>>
>> +config XILINX_WATCHDOG
>> + tristate "Xilinx Watchdog timer"
>> + select WATCHDOG_CORE
>> + help
>> + Watchdog driver for the xps_timebase_wdt ip core.
>> +
>> + To compile this driver as a module, choose M here: the
>> + module will be called of_xilinx_wdt.
>> +
>> # ALPHA Architecture
>>
>> # ARM Architecture
>> @@ -1022,19 +1031,6 @@ config M54xx_WATCHDOG
>>
>> # MicroBlaze Architecture
>>
>> -config XILINX_WATCHDOG
>> - tristate "Xilinx Watchdog timer"
>> - depends on MICROBLAZE
>> - select WATCHDOG_CORE
>> - ---help---
>> - Watchdog driver for the xps_timebase_wdt ip core.
>> -
>> - IMPORTANT: The xps_timebase_wdt parent must have the property
>> - "clock-frequency" at device tree.
>> -
>> - To compile this driver as a module, choose M here: the
>> - module will be called of_xilinx_wdt.
>> -
>> # MIPS Architecture
>>
>> config ATH79_WDT
>> --
>> 1.8.2.3
>>
>
> Are we sure that we don't need an additional dependancy (like depends on HAS_IOMEM) to not have issues with other architectures?
>
Hi Wim,
Doesn't look like it. I have the series in my build test and did not
see any failures because of it. See http://server.roeck-us.net:8010/builders,
branch watchdog-next.
Which reminds me that I wanted to reparent the branch to 3.14-rc3.
I just did that; you should be able to see build results in a couple
of hours.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/11] watchdog: xilinx: Enable this driver for Zynq
Date: Sat, 22 Feb 2014 12:42:23 -0800 [thread overview]
Message-ID: <53090BAF.3080806@roeck-us.net> (raw)
In-Reply-To: <20140222184419.GA21504@spo001.leaseweb.com>
On 02/22/2014 10:44 AM, Wim Van Sebroeck wrote:
> Hi Michal,
>
>> Enable this driver for Zynq.
>> Move it to architecture independent Kconfig part.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>> Build tested by zero day testing system.
>> ---
>> drivers/watchdog/Kconfig | 22 +++++++++-------------
>> 1 file changed, 9 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index 9db5d3c..6120403 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -111,6 +111,15 @@ config WM8350_WATCHDOG
>> Support for the watchdog in the WM8350 AudioPlus PMIC. When
>> the watchdog triggers the system will be reset.
>>
>> +config XILINX_WATCHDOG
>> + tristate "Xilinx Watchdog timer"
>> + select WATCHDOG_CORE
>> + help
>> + Watchdog driver for the xps_timebase_wdt ip core.
>> +
>> + To compile this driver as a module, choose M here: the
>> + module will be called of_xilinx_wdt.
>> +
>> # ALPHA Architecture
>>
>> # ARM Architecture
>> @@ -1022,19 +1031,6 @@ config M54xx_WATCHDOG
>>
>> # MicroBlaze Architecture
>>
>> -config XILINX_WATCHDOG
>> - tristate "Xilinx Watchdog timer"
>> - depends on MICROBLAZE
>> - select WATCHDOG_CORE
>> - ---help---
>> - Watchdog driver for the xps_timebase_wdt ip core.
>> -
>> - IMPORTANT: The xps_timebase_wdt parent must have the property
>> - "clock-frequency" at device tree.
>> -
>> - To compile this driver as a module, choose M here: the
>> - module will be called of_xilinx_wdt.
>> -
>> # MIPS Architecture
>>
>> config ATH79_WDT
>> --
>> 1.8.2.3
>>
>
> Are we sure that we don't need an additional dependancy (like depends on HAS_IOMEM) to not have issues with other architectures?
>
Hi Wim,
Doesn't look like it. I have the series in my build test and did not
see any failures because of it. See http://server.roeck-us.net:8010/builders,
branch watchdog-next.
Which reminds me that I wanted to reparent the branch to 3.14-rc3.
I just did that; you should be able to see build results in a couple
of hours.
Guenter
next prev parent reply other threads:[~2014-02-22 20:42 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 13:34 [PATCH v3 0/11] Xilinx watchdog changes Michal Simek
2014-02-12 13:34 ` Michal Simek
2014-02-12 13:34 ` [PATCH v3 01/11] watchdog: xilinx: Convert driver to the watchdog framework Michal Simek
2014-02-12 13:34 ` Michal Simek
2014-02-12 13:34 ` [PATCH v3 02/11] watchdog: xilinx: Move control_status_reg to functions Michal Simek
2014-02-12 13:34 ` Michal Simek
2014-02-12 13:34 ` [PATCH v3 03/11] watchdog: xilinx: Simplify probe and remove functions Michal Simek
2014-02-12 13:34 ` Michal Simek
2014-02-12 13:34 ` [PATCH v3 04/11] watchdog: xilinx: Move no_timeout to probe function Michal Simek
2014-02-12 13:34 ` Michal Simek
2014-02-12 13:41 ` [PATCH v3 05/11] watchdog: xilinx: Allocate private structure per device Michal Simek
2014-02-12 13:41 ` Michal Simek
2014-02-12 13:41 ` [PATCH v3 06/11] watchdog: xilinx: Fix all printk messages Michal Simek
2014-02-12 13:41 ` Michal Simek
2014-02-12 13:41 ` [PATCH v3 07/11] watchdog: xilinx: Use of_property_read_u32 Michal Simek
2014-02-12 13:41 ` Michal Simek
2014-02-12 17:15 ` Guenter Roeck
2014-02-12 17:15 ` Guenter Roeck
2014-02-22 18:46 ` Wim Van Sebroeck
2014-02-23 1:08 ` Alejandro Cabrera
2014-02-23 1:08 ` Alejandro Cabrera
2014-02-22 23:18 ` Guenter Roeck
2014-02-22 23:18 ` Guenter Roeck
2014-02-23 3:52 ` Alejandro Cabrera
2014-02-23 3:52 ` Alejandro Cabrera
2014-02-23 1:36 ` Guenter Roeck
2014-02-23 1:36 ` Guenter Roeck
2014-02-23 6:14 ` Alejandro Cabrera
2014-02-23 6:14 ` Alejandro Cabrera
2014-02-23 3:44 ` Guenter Roeck
2014-02-23 3:44 ` Guenter Roeck
2014-02-23 16:25 ` Alejandro Cabrera
2014-02-23 16:25 ` Alejandro Cabrera
2014-02-23 14:43 ` Guenter Roeck
2014-02-23 14:43 ` Guenter Roeck
2014-02-23 19:00 ` Alejandro Cabrera
2014-02-23 19:00 ` Alejandro Cabrera
2014-02-24 8:52 ` Michal Simek
2014-02-24 8:52 ` Michal Simek
2014-02-24 19:25 ` Wim Van Sebroeck
2014-02-25 7:39 ` Michal Simek
2014-02-25 7:39 ` Michal Simek
2014-02-12 13:41 ` [PATCH v3 08/11] watchdog: xilinx: Use correct comment indentation Michal Simek
2014-02-12 13:41 ` Michal Simek
2014-02-12 13:41 ` [PATCH v3 09/11] watchdog: xilinx: Add missing binding Michal Simek
2014-02-12 13:41 ` Michal Simek
2014-02-12 13:41 ` [PATCH v3 10/11] watchdog: xilinx: Enable this driver for Zynq Michal Simek
2014-02-12 13:41 ` Michal Simek
2014-02-22 18:44 ` Wim Van Sebroeck
2014-02-22 20:42 ` Guenter Roeck [this message]
2014-02-22 20:42 ` Guenter Roeck
2014-02-12 13:41 ` [PATCH v3 11/11] watchdog: xilinx: Remove no_timeout variable Michal Simek
2014-02-12 13:41 ` Michal Simek
2014-02-24 20:01 ` [PATCH v3 0/11] Xilinx watchdog changes Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53090BAF.3080806@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.