From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix uninitialized members when setting PFC
Date: Tue, 4 Feb 2020 18:25:26 +0000 [thread overview]
Message-ID: <5309eb17-ac0f-e671-78be-e1d032f486e3@intel.com> (raw)
In-Reply-To: <dd1f0e9e-fa82-d266-46a6-09b970406002@intel.com>
On 1/28/2020 11:21 AM, Ferruh Yigit wrote:
> On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote:
>> From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
>>
>> Only a part of members in the local structure variable named pfc_conf are
>> initialized in the function named cmd_priority_flow_ctrl_set_parsed when
>> typing "set pfc_ctrl..." command, and others are random values. However,
>> those uninitialized members may cause failure.
>>
>> This patch adds clearing zero operation before calling the API named
>> rte_eth_dev_priority_flow_ctrl_set API with pfc_conf as the input
>> parameter.
>>
>> Fixes: 9b53e542e9e1 ("app/testpmd: add priority flow control")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Xuan Li <lixuan47@hisilicon.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2020-02-04 18:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 11:44 [dpdk-dev] [PATCH 0/3] app/testpmd: fixes for testpmd application Wei Hu (Xavier)
2020-01-21 11:44 ` [dpdk-dev] [PATCH 1/3] app/testpmd: update Rx offload after setting MTU sccessfully Wei Hu (Xavier)
2020-01-28 11:27 ` Ferruh Yigit
2020-02-12 0:25 ` Wei Hu (Xavier)
2020-02-13 1:52 ` Wei Hu (Xavier)
2020-01-21 11:44 ` [dpdk-dev] [PATCH 2/3] app/testpmd: fix the initial value when setting PFC Wei Hu (Xavier)
2020-01-28 11:21 ` Ferruh Yigit
2020-02-04 18:25 ` Ferruh Yigit
2020-01-21 11:44 ` [dpdk-dev] [PATCH 3/3] app/testpmd: fix uninitialized members " Wei Hu (Xavier)
2020-01-28 11:21 ` Ferruh Yigit
2020-02-04 18:25 ` Ferruh Yigit [this message]
2020-02-04 18:24 ` [dpdk-dev] [PATCH 0/3] app/testpmd: fixes for testpmd application Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5309eb17-ac0f-e671-78be-e1d032f486e3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=huwei013@chinasoftinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.