From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK
 board
Date: Mon, 24 Feb 2014 09:18:48 +0900
Message-ID: <530A8FE8.4020903@samsung.com>
References: <1386236664-27763-1-git-send-email-sachin.kamat@linaro.org>	<6615089.743e1d93MS@amdc1227>	<CAK9yfHy8iKr8n5OVLm3QbiO3cL_hx-kr8f=gZ2VsBmuXLgHvgg@mail.gmail.com>	<1604811.B6Si6qrpKm@flatron> <CAK9yfHyu=ZKrPqb_VC-6RoJOF=W45jJrZ95=zYmvkMzd_oEooQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-samsung-soc-owner@vger.kernel.org>
Received: from mail-pa0-f54.google.com ([209.85.220.54]:39330 "EHLO
	mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750976AbaBXAS5 (ORCPT
	<rfc822;linux-samsung-soc@vger.kernel.org>);
	Sun, 23 Feb 2014 19:18:57 -0500
Received: by mail-pa0-f54.google.com with SMTP id fa1so5785513pad.27
        for <linux-samsung-soc@vger.kernel.org>; Sun, 23 Feb 2014 16:18:55 -0800 (PST)
In-Reply-To: <CAK9yfHyu=ZKrPqb_VC-6RoJOF=W45jJrZ95=zYmvkMzd_oEooQ@mail.gmail.com>
Sender: linux-samsung-soc-owner@vger.kernel.org
List-Id: linux-samsung-soc@vger.kernel.org
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, Kukjin Kim <kgene.kim@samsung.com>

On 01/03/14 19:07, Sachin Kamat wrote:
> On 21 December 2013 02:40, Tomasz Figa<tomasz.figa@gmail.com>  wrote:
>> On Thursday 19 of December 2013 10:05:52 Sachin Kamat wrote:
>>> Hi Tomasz,
>>>
>>> On 18 December 2013 20:46, Tomasz Figa<t.figa@samsung.com>  wrote:
>>>> Hi Sachin,
>>>>
>>>> On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:
>>>>> Added regulator entries to Exynos5420 SMDK board.
>>>>>
>>>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>>>> ---
>>>>> Changes since v1:
>>>>> Changed node name
>>>>> ---
>>>>>   arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 +++++++++++++++++++++++++++++
>>>>>   1 file changed, 216 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>>>>> index fb5a1e25c632..62e1ebe4e989 100644
>>>>> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
>>>>> @@ -120,4 +120,220 @@
>>>>>                        reg =<0x50>;
>>>>>                };
>>>>>        };
>>>>> +
>>>>> +     hsi2c_4: i2c@12CA0000 {
>>>>> +             status = "okay";
>>>>> +
>>>>> +             s2mps11_pmic@66 {
>>>>
>>>> Just pmic@66 is enough.
>>>
>>> Please see my comment below.
>>>
>>>>
>>>>> +                     compatible = "samsung,s2mps11-pmic";
>>>>> +                     reg =<0x66>;
>>>>> +                     s2mps11,buck2-ramp-delay =<12>;
>>>>> +                     s2mps11,buck34-ramp-delay =<12>;
>>>>> +                     s2mps11,buck16-ramp-delay =<12>;
>>>>> +                     s2mps11,buck6-ramp-enable =<1>;
>>>>> +                     s2mps11,buck2-ramp-enable =<1>;
>>>>> +                     s2mps11,buck3-ramp-enable =<1>;
>>>>> +                     s2mps11,buck4-ramp-enable =<1>;
>>>>> +
>>>>> +                     s2mps11_osc: clocks {
>>>>> +                             #clock-cells =<1>;
>>>>> +                             clock-output-names = "s2mps11_ap",
>>>>> +                                             "s2mps11_cp", "s2mps11_bt";
>>>>> +                     };
>>>>> +
>>>>> +                     regulators {
>>>>> +                             ldo1_reg: LDO1 {
>>>>> +                                     regulator-name = "vdd_ldo1";
>>>>
>>>> Is this the name as written on the PCB or board schematics?
>>>> + the same for all regulators below.
>>>
>>> Yes, the schematic refers to these just as above (with no specific names).
>>> Unless you have strong objections or a re-spin of this patch becomes
>>> necessary, I
>>> wouldn't want to change the name you pointed above. :)
>>
>> OK.
>>
>> Reviewed-by: Tomasz Figa<t.figa@samsung.com>
>
> Ping Kukjin.
>
Applied, thanks.

- Kukjin