Re: [PATCH] mmc: sdhci: add quirk for broken write protect detection

[Eli Billauer <eli.billauer@gmail.com>]

Hello Chris.

On 24/02/14 02:12, Chris Ball wrote:
> Hi Eli,
>
> On Sun, Feb 23 2014, Eli Billauer wrote:
>    
>> The write protection signal is absent on a board based upon Xilinx' Zynq
>> processor ("ZyBo"). This leads the kernel to think that the MicroSD card is
>> write protected, and causes a kernel panic during boot, as root fails to
>> mount RW.
>>
>> This patch adds a quirk and an optional OF property, sdhci,wp-broken to
>> work around this issue.
>>      
> Just to confirm your motivation for the patch:  wp-inverted would solve
> this problem for you, but you'd rather add a new property that more
> accurately describes the hardware?
>    
Yes, that's the point.
> (We'd probably use broken-wp, for symmetry with the existing broken-cd.)
>    
I picked "sdhci,wp-broken" because of the similarity with 
"sdhci,wp-inverted", as opposed to "broken-cd" (with no "sdhci," prefix).

Would you like me to resubmit the patch with "broken-wp"? Or maybe 
"sdhci,broken-wp"?

Regards,
    Eli