From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v1 1/3] clk: Add function to parse an arbitrary clocks list property
Date: Mon, 24 Feb 2014 11:43:27 +0100 [thread overview]
Message-ID: <530B224F.6010104@samsung.com> (raw)
In-Reply-To: <20140224004335.22529.74369@quantum>
On 24/02/14 01:43, Mike Turquette wrote:
[...]
>> > +/**
>> > + * of_clk_get_list_entry() - Parse and lookup a clock referenced by a device node
>> > + * @np: pointer to clock consumer node
>> > + * @list_name: name of the clock list property
>> > + * @index: index to the clock list
>> > + *
>> > + * This function parses the @list_name property and together with @index
>> > + * value indicating an entry of the list uses it to look up the struct clk
>> > + * from the registered list of clock providers.
>> > + */
>> > +struct clk *of_clk_get_list_entry(struct device_node *np,
>> > + const char *list_name, int index)
>
> Bikeshed alert: how about of_clk_get_by_property or of_clk_get_by_prop?
That sounds better to me, thanks for the suggestion.
For the next iteration I'm going to use of_clk_get_by_property() .
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH RFC v1 1/3] clk: Add function to parse an arbitrary clocks list property
Date: Mon, 24 Feb 2014 11:43:27 +0100 [thread overview]
Message-ID: <530B224F.6010104@samsung.com> (raw)
In-Reply-To: <20140224004335.22529.74369@quantum>
On 24/02/14 01:43, Mike Turquette wrote:
[...]
>> > +/**
>> > + * of_clk_get_list_entry() - Parse and lookup a clock referenced by a device node
>> > + * @np: pointer to clock consumer node
>> > + * @list_name: name of the clock list property
>> > + * @index: index to the clock list
>> > + *
>> > + * This function parses the @list_name property and together with @index
>> > + * value indicating an entry of the list uses it to look up the struct clk
>> > + * from the registered list of clock providers.
>> > + */
>> > +struct clk *of_clk_get_list_entry(struct device_node *np,
>> > + const char *list_name, int index)
>
> Bikeshed alert: how about of_clk_get_by_property or of_clk_get_by_prop?
That sounds better to me, thanks for the suggestion.
For the next iteration I'm going to use of_clk_get_by_property() .
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-24 10:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 16:58 [PATCH RFC v1 0/3] clk: Support for DT assigned clk parent and rate Sylwester Nawrocki
2014-02-19 16:58 ` Sylwester Nawrocki
[not found] ` < 1392829124-25705-4-git-send-email-s.nawrocki@samsung.com>
2014-02-19 16:58 ` [PATCH RFC v1 1/3] clk: Add function to parse an arbitrary clocks list property Sylwester Nawrocki
2014-02-19 16:58 ` Sylwester Nawrocki
2014-02-24 0:43 ` Mike Turquette
2014-02-24 0:43 ` Mike Turquette
2014-02-24 10:43 ` Sylwester Nawrocki [this message]
2014-02-24 10:43 ` Sylwester Nawrocki
2014-02-19 16:58 ` [PATCH RFC v1 2/3] of: Add definition of maximum length of a property name Sylwester Nawrocki
2014-02-19 16:58 ` Sylwester Nawrocki
2014-02-19 21:42 ` Rob Herring
2014-02-19 21:42 ` Rob Herring
2014-02-20 15:02 ` Sylwester Nawrocki
2014-02-20 15:02 ` Sylwester Nawrocki
2014-02-19 16:58 ` [PATCH RFC v1 3/3] clk: Add handling of clk parent and rate assigned from DT Sylwester Nawrocki
2014-02-19 16:58 ` Sylwester Nawrocki
2014-02-20 14:09 ` Grant Likely
2014-02-20 14:09 ` Grant Likely
2014-02-21 10:38 ` Sylwester Nawrocki
2014-02-21 10:38 ` Sylwester Nawrocki
2014-02-24 0:48 ` Mike Turquette
2014-02-24 0:48 ` Mike Turquette
2014-02-24 18:11 ` Sylwester Nawrocki
2014-02-24 18:11 ` Sylwester Nawrocki
2014-03-01 21:13 ` Grant Likely
2014-03-01 21:13 ` Grant Likely
2014-03-01 21:11 ` Grant Likely
2014-03-01 21:11 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B224F.6010104@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.