From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v2 02/15] xen/passthrough: vtd: Don't export
 iommu_domain_teardown
Date: Mon, 24 Feb 2014 12:10:53 +0000
Message-ID: <530B36CD.3020302@linaro.org>
References: <1393193792-20008-1-git-send-email-julien.grall@linaro.org>
	<1393193792-20008-3-git-send-email-julien.grall@linaro.org>
	<530B3C5C020000780011EB3D@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1WHuN9-00073T-0x
	for xen-devel@lists.xenproject.org; Mon, 24 Feb 2014 12:10:59 +0000
Received: by mail-ee0-f47.google.com with SMTP id e49so914090eek.6
	for <xen-devel@lists.xenproject.org>;
	Mon, 24 Feb 2014 04:10:57 -0800 (PST)
In-Reply-To: <530B3C5C020000780011EB3D@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, ian.campbell@citrix.com, Xiantao Zhang <xiantao.zhang@intel.com>, tim@xen.org
List-Id: xen-devel@lists.xenproject.org

On 02/24/2014 11:34 AM, Jan Beulich wrote:
>>>> On 23.02.14 at 23:16, Julien Grall <julien.grall@linaro.org> wrote:
>> iommu_domain_teardown is only used internally in
>> xen/drivers/passthrough/vtd/iommu.c
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> Acked-by: Ian Cambell <ian.campbell@citrix.com>
>> Cc: Xiantao Zhang <xiantao.zhang@intel.com>
>> ---
>>  xen/drivers/passthrough/vtd/iommu.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/drivers/passthrough/vtd/iommu.c 
>> b/xen/drivers/passthrough/vtd/iommu.c
>> index 5f10034..a8d33fc 100644
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -1701,7 +1701,7 @@ static int reassign_device_ownership(
>>      return ret;
>>  }
>>  
>> -void iommu_domain_teardown(struct domain *d)
>> +static void iommu_domain_teardown(struct domain *d)
>>  {
>>      struct hvm_iommu *hd = domain_hvm_iommu(d);
>>  
> 
> Please build-test your changes - this was lacking the removal of
> the function's declaration from xen/iommu.h.

Actually I did the build test on x86 ... By mistake I remove the
function's declaration in the wrong patch "xen/passthrough: iommu: Split
generic IOMMU code".

I will fix it in the next patch series.

Cheers,

-- 
Julien Grall