From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60199)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WHui2-0008CF-22
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 07:32:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WHuhv-0007Sh-VQ
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 07:32:33 -0500
Received: from cantor2.suse.de ([195.135.220.15]:48280 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WHuhv-0007SS-PO
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 07:32:27 -0500
Message-ID: <530B3BD8.4030204@suse.de>
Date: Mon, 24 Feb 2014 13:32:24 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1393244541-29715-1-git-send-email-kraxel@redhat.com>
	<1393244541-29715-2-git-send-email-kraxel@redhat.com>
In-Reply-To: <1393244541-29715-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 1/1] hda-audio: qom cleanups
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Vassili Karpov (malc)" <av1474@comtv.ru>

Am 24.02.2014 13:22, schrieb Gerd Hoffmann:
> Add HDA_AUDIO type and macro, drop DO_UPCAST().
>=20
> Had to add a abstract hda audio class as parent
> for all hda-* variants to make that fly.  Killed
> some init code duplication while being at it.
>=20
> Cc: Andreas F=C3=A4rber <afaerber@suse.de>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/audio/hda-codec.c | 60 ++++++++++++++++++++++++++++----------------=
--------
>  1 file changed, 32 insertions(+), 28 deletions(-)

Looks good, including introduction of a base type, thanks for cleaning
this up. These devices are not used by default, right? Have you been
considering writing qtests for them or would you rather have me prepare
something?

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg