From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
ccross@google.com, linux-media@vger.kernel.org
Subject: Re: [PATCH 4/6] android: convert sync to fence api, v4
Date: Mon, 24 Feb 2014 14:01:13 +0100 [thread overview]
Message-ID: <530B4299.3090508@canonical.com> (raw)
In-Reply-To: <5304B7F9.4070907@vmware.com>
op 19-02-14 14:56, Thomas Hellstrom schreef:
>> >+static void fence_check_cb_func(struct fence *f, struct fence_cb *cb)
>> >+{
>> >+ struct sync_fence_cb *check = container_of(cb, struct sync_fence_cb, cb);
>> >+ struct sync_fence *fence = check->fence;
>> >+
>> >+ // TODO: Add a fence->status member and check it
> Hmm, C++ / C99 style comments makes checkpatch.pl complain. Did you run
> this series through checkpatch?
>
> /Thomas
>
Actually I used c99 here because it shouldn't have been in the sent patch. ;-)
Right below that comment I use fence->status, so the right thing to do was to zap the comment.
Thanks for catching it!
~Maarten\
next prev parent reply other threads:[~2014-02-24 13:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 15:55 [PATCH 0/6] dma-buf synchronization patches Maarten Lankhorst
2014-02-17 15:55 ` [PATCH 1/6] fence: dma-buf cross-device synchronization (v17) Maarten Lankhorst
2014-02-17 15:55 ` Maarten Lankhorst
2014-02-17 16:56 ` Rob Clark
2014-02-17 15:56 ` [PATCH 2/6] seqno-fence: Hardware dma-buf implementation of fencing (v4) Maarten Lankhorst
2014-02-17 15:56 ` Maarten Lankhorst
2014-02-17 16:55 ` Rob Clark
2014-02-17 16:55 ` Rob Clark
2014-02-17 16:56 ` Christian König
2014-02-17 16:56 ` Christian König
2014-02-17 17:27 ` Rob Clark
2014-02-17 17:27 ` Rob Clark
2014-02-17 17:36 ` Christian König
2014-02-17 18:24 ` Rob Clark
2014-02-17 18:41 ` Christian König
2014-02-17 18:41 ` Christian König
2014-02-19 13:25 ` Maarten Lankhorst
2014-03-03 21:01 ` Daniel Vetter
2014-02-17 15:56 ` [PATCH 3/6] dma-buf: use reservation objects Maarten Lankhorst
2014-02-17 15:56 ` Maarten Lankhorst
2014-02-17 16:46 ` Rob Clark
2014-02-19 13:58 ` Thomas Hellstrom
2014-02-19 13:58 ` Thomas Hellstrom
2014-02-17 15:57 ` [PATCH 4/6] android: convert sync to fence api, v4 Maarten Lankhorst
2014-02-17 15:57 ` Maarten Lankhorst
2014-02-19 13:56 ` Thomas Hellstrom
2014-02-24 13:01 ` Maarten Lankhorst [this message]
2014-03-03 21:11 ` Daniel Vetter
2014-03-04 7:50 ` Maarten Lankhorst
2014-03-04 7:50 ` Maarten Lankhorst
2014-03-04 8:14 ` Daniel Vetter
2014-03-04 8:20 ` Maarten Lankhorst
2014-03-04 10:00 ` Daniel Vetter
2014-03-04 10:42 ` Maarten Lankhorst
2014-02-17 15:58 ` [PATCH 5/6] reservation: add support for fences to enable cross-device synchronisation Maarten Lankhorst
2014-02-17 16:54 ` Rob Clark
2014-02-17 16:54 ` Rob Clark
2014-02-17 15:58 ` [PATCH 6/6] dma-buf: add poll support, v2 Maarten Lankhorst
2014-02-17 15:58 ` Maarten Lankhorst
2014-02-17 16:38 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B4299.3090508@canonical.com \
--to=maarten.lankhorst@canonical.com \
--cc=ccross@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.