All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Fam Zheng <famz@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] compressed VMDKs and BDRV_BLOCK_OFFSET_VALID
Date: Mon, 24 Feb 2014 14:48:26 +0100	[thread overview]
Message-ID: <530B4DAA.6070301@kamp.de> (raw)

Hi,

I wonder if the current output of get_block_status for compressed VMDKs is correct or
if we need this patch?:

diff --git a/block/vmdk.c b/block/vmdk.c
index ff6f5ee..5fa29b0 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs,
          break;
      case VMDK_OK:
          ret = BDRV_BLOCK_DATA;
-        if (extent->file == bs->file) {
+        if (extent->file == bs->file && !extent->compressed) {
              ret |= BDRV_BLOCK_OFFSET_VALID | offset;
          }

Peter

             reply	other threads:[~2014-02-24 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 13:48 Peter Lieven [this message]
2014-02-24 14:37 ` [Qemu-devel] compressed VMDKs and BDRV_BLOCK_OFFSET_VALID Fam Zheng
2014-02-24 16:39   ` Paolo Bonzini
2014-02-24 20:22     ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530B4DAA.6070301@kamp.de \
    --to=pl@kamp.de \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.