Re: [PATCH] net: stmmac: Check return value of alloc_dma_desc_resources()

[Giuseppe CAVALLARO <peppe.cavallaro@st.com>]

On 2/22/2014 1:09 PM, Tobias Klauser wrote:
> alloc_dma_desc_resources() returns an error value and the next line
> actually checks for it, so assign the return value properly.
>
> Found by the coverity scanner.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>

> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index a2e7d2c..078ad0e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -1705,7 +1705,7 @@ static int stmmac_open(struct net_device *dev)
>   	priv->dma_rx_size = STMMAC_ALIGN(dma_rxsize);
>   	priv->dma_buf_sz = STMMAC_ALIGN(buf_sz);
>
> -	alloc_dma_desc_resources(priv);
> +	ret = alloc_dma_desc_resources(priv);
>   	if (ret < 0) {
>   		pr_err("%s: DMA descriptors allocation failed\n", __func__);
>   		goto dma_desc_error;
>