Re: [Qemu-devel] [PATCH] Add a command to QMP to list the supported devices

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On 02/24/2014 02:23 AM, Or Goshen wrote:
> From: Or Goshen <or@heartbeat.com>
> 
> Was done on behalf of Intel Corp.
> 
> ---

> +++ b/qapi-schema.json
> @@ -526,6 +526,32 @@
>  { 'command': 'query-commands', 'returns': ['CommandInfo'] }
>  
>  ##
> +# @DeviceInfo:
> +#
> +# Information about a device
> +#
> +# @name: The command name
> +# @bus: The bus it is connected to
> +# @alias: Device alias
> +# @desc: Description of the device
> +#
> +# Since: 1.6.0

This needs to be 2.0 (or whatever actual release it first makes it
into), not 1.6.0.

> +##
> +{ 'type': 'DeviceInfo', 'data': {'name': 'str', 'bus': 'str', 'alias': 'str', 'desc': 'str'} }
> +
> +##
> +# @query-devices:
> +#
> +# Return a list of supported devices
> +#
> +# Returns: A list of @DeviceInfo for all supported devices
> +#
> +# Since: 1.6.0

and again


> +-> { "execute": "query-devices" }
> +<- {
> +      "return":[
> +         {
> +            "name":"pci-bridge",
> +            "bus":"PCI",
> +            "alias":"",

Should alias be optional, rather than an empty string, when there isn't one?

> +            "desc":"Standard PCI Bridge"

Is the description intended to be machine parseable, or is it only for
human consumption?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]