From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] tools/console: reset tty when xenconsole fails Date: Mon, 24 Feb 2014 16:17:10 +0000 Message-ID: <530B7086.2010309@eu.citrix.com> References: <1393255564-3474-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393255564-3474-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xensource.com Cc: Ian Campbell , M A Young List-Id: xen-devel@lists.xenproject.org On 02/24/2014 03:26 PM, Ian Jackson wrote: > If xenconsole (the client program) fails, it calls err. This would > previously neglect to reset the user's terminal to sanity. Use atexit > to do so. > > This routinely happens in Xen 4.4 RC5 with pygrub because something > writes the value "" to the tty xenstore key when using xenconsole. > The cause of this is not yet known, but after this patch it just > results in a harmless error message. > > Reported-by: M A Young > Signed-off-by: Ian Jackson I'm pretty sure this has been here for quite a while -- possibly since 4.3. I've been working around it for some time, at any rate. :-) So I think at this point we should save this for 4.4.1. -George