Re: [PATCH v3 4/5] xen: Misc cleanup as a result of the previous patches

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 24/02/14 16:06, Jan Beulich wrote:
>>>> On 24.02.14 at 16:01, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/arch/x86/mm/shadow/common.c
>> +++ b/xen/arch/x86/mm/shadow/common.c
>> @@ -875,7 +875,6 @@ static int sh_skip_sync(struct vcpu *v, mfn_t gl1mfn)
>>      SHADOW_ERROR("gmfn %#lx was OOS but not shadowed as an l1.\n",
>>                   mfn_x(gl1mfn));
>>      BUG();
>> -    return 0; /* BUG() is no longer __attribute__((noreturn)). */
>>  }
> Did you check that this is fine with the whole range of compiler
> versions we support? Also, s/no longer/now/ ?
>
> Jan
>

It was tested on GCC 4.1.1 from the old XenServer build system, which I
believe is the oldest GCC we support.

BUG() for a while lost noreturn, then had it reintroduced by Tim in
d2fd6f2b01ed0e "x86: mark BUG()s and assertion failures as terminal."

~Andrew