From: David Vrabel <david.vrabel@citrix.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Michael Opdenacker <michael.opdenacker@free-electrons.com>,
<x86@kernel.org>, <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>,
Richard Weinberger <richard@nod.at>
Subject: Re: [Xen-devel] [PATCH v2] xen: remove XEN_PRIVILEGED_GUEST
Date: Mon, 24 Feb 2014 18:51:35 +0000 [thread overview]
Message-ID: <530B94B7.5080602@citrix.com> (raw)
In-Reply-To: <1392728861.5144.10.camel@x220>
On 18/02/14 13:07, Paul Bolle wrote:
> This patch removes the Kconfig symbol XEN_PRIVILEGED_GUEST which is
> used nowhere in the tree.
>
> We do know grub2 has a script that greps kernel configuration files for
> its macro. It shouldn't do that. As Linus summarized:
> This is a grub bug. It really is that simple. Treat it as one.
>
> Besides, grub2's grepping for that macro is actually superfluous. See,
> that script currently contains this test (simplified):
> grep -x CONFIG_XEN_DOM0=y $config || grep -x CONFIG_XEN_PRIVILEGED_GUEST=y $config
>
> But since XEN_DOM0 and XEN_PRIVILEGED_GUEST are by definition equal,
> removing XEN_PRIVILEGED_GUEST cannot influence this test.
>
> So there's no reason to not remove this symbol, like we do with all
> unused Kconfig symbols.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2014-02-24 18:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 12:23 [PATCH] xen: remove XEN_PRIVILEGED_GUEST Konrad Rzeszutek Wilk
2014-02-17 13:03 ` Paul Bolle
2014-02-17 13:03 ` Paul Bolle
2014-02-17 14:43 ` Konrad Rzeszutek Wilk
2014-02-18 10:14 ` Paul Bolle
2014-02-18 10:14 ` Paul Bolle
2014-02-18 13:07 ` [PATCH v2] " Paul Bolle
2014-02-18 13:07 ` Paul Bolle
2014-02-18 13:13 ` Paul Bolle
2014-02-18 13:13 ` Paul Bolle
2014-02-24 18:51 ` David Vrabel
2014-02-24 18:51 ` David Vrabel [this message]
2014-02-24 18:39 ` [PATCH] " Konrad Rzeszutek Wilk
2014-02-24 18:39 ` [Xen-devel] " Konrad Rzeszutek Wilk
2014-02-24 19:38 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-02-24 19:38 ` [Xen-devel] " Vladimir 'φ-coder/phcoder' Serbinenko
2014-02-28 20:54 ` Paul Bolle
2014-02-28 20:54 ` Paul Bolle
2014-02-17 14:43 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B94B7.5080602@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=mingo@redhat.com \
--cc=pebolle@tiscali.nl \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.