From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WI4Vf-0006Mf-2D
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 18:00:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WI4VX-0005SP-PK
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 18:00:26 -0500
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:38238)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1WI4VX-0005Qx-Is
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 18:00:19 -0500
Message-ID: <530BCEF0.2010707@weilnetz.de>
Date: Tue, 25 Feb 2014 00:00:00 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1393174935-11750-1-git-send-email-sw@weilnetz.de>
	<1393174935-11750-7-git-send-email-sw@weilnetz.de>
	<530B1E66.8080200@redhat.com>
In-Reply-To: <530B1E66.8080200@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include
	file for windows.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Jan Kiszka <jan.kiszka@siemens.com>

Am 24.02.2014 11:26, schrieb Paolo Bonzini:
> Il 23/02/2014 18:02, Stefan Weil ha scritto:
>> diff --git a/qga/channel-win32.c b/qga/channel-win32.c
>> index 8a303f3..3a0bf13 100644
>> --- a/qga/channel-win32.c
>> +++ b/qga/channel-win32.c
>> @@ -2,7 +2,7 @@
>>  #include <stdio.h>
>>  #include <stdbool.h>
>>  #include <glib.h>
>> -#include <windows.h>
>> +#include "sysemu/os-winapi.h"
>>  #include <errno.h>
>>  #include <io.h>
>>  #include "qga/guest-agent-core.h"
> 
> qga/ is not supposed to include include/sysemu (which is just for
> qemu-system-*).  I guess you can call the new file include/qemu/winapi.h
> 
> Paolo

Ah, thanks for explaining. I'll use the suggested name in an updated
series. But you are aware that qga/ already includes sysemu/os-posix.h
and sysemu/os-win32.h indirectly? Should those two files also be in
include/qemu?

Stefan