From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI4dC-00018Q-GA for qemu-devel@nongnu.org; Mon, 24 Feb 2014 18:08:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WI4d5-0008Cj-Px for qemu-devel@nongnu.org; Mon, 24 Feb 2014 18:08:14 -0500 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:38679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WI4d5-0008BT-Jr for qemu-devel@nongnu.org; Mon, 24 Feb 2014 18:08:07 -0500 Message-ID: <530BD0CE.5070304@weilnetz.de> Date: Tue, 25 Feb 2014 00:07:58 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1393174935-11750-1-git-send-email-sw@weilnetz.de> <1393174935-11750-10-git-send-email-sw@weilnetz.de> <530B4429.1020307@suse.de> In-Reply-To: <530B4429.1020307@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Anthony Liguori , Stefan Hajnoczi Am 24.02.2014 14:07, schrieb Andreas F=E4rber: > Am 23.02.2014 18:02, schrieb Stefan Weil: >> These header files are used by most QEMU source files. If they >> depend on windows.h, all those source files do so, too. >> [...] >=20 > First of all, why was I not CC'ed on this change? > File is listed under "CPU" subsystem in MAINTAINERS. >=20 > Patches not getting sufficient review is one risk, causing merge > conflicts another. People should be aware of changes you make in their > files, even if "just" Windows-related. Sorry, I simply missed your name in the lengthy output from get_maintainer.pl. > I had moved the field unchanged from another header, I believe. I don't > think this is a good change (assuming the Windows API is still using > this type and not void*), especially since it's #ifdef'ed anyway. Please see my mail to Kevin (which will be sent in a moment). >=20 > And I don't understand why reducing the number of files dependent on > windows.h is a good thing either. Your cover letter does not explain. > We've not been trying to reduce dependencies on glib either, nor is > there precedence for replacing other pointer types elsewhere (e.g. > qemu_irq). Wherever possible, we've been using the most precise pointer > type to let the compiler or static analysis tools help us catch mismatc= hes. See also my other mail. >=20 > Is all this just to speed up rebuilds after MinGW updates? The .d files don't track dependencies to system include files. A MinGW update won't trigger new compilations, so this is not a reason at all. Regards Stefan