From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH 1/1] ARM: Exynos: Add generic compatible string Date: Tue, 25 Feb 2014 10:00:49 +0900 Message-ID: <530BEB41.5070107@samsung.com> References: <1392809645-631-1-git-send-email-sachin.kamat@linaro.org> <53075239.4010603@samsung.com> <2200834.G3JJLYQl5i@wuerfel> <53076F00.7000001@samsung.com> <53077160.5030202@samsung.com> <530BE557.20106@samsung.com> <530BE93F.2070904@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f49.google.com ([209.85.160.49]:54978 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbaBYBBF (ORCPT ); Mon, 24 Feb 2014 20:01:05 -0500 In-Reply-To: <530BE93F.2070904@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tomasz Figa Cc: Kukjin Kim , Sachin Kamat , Mark Rutland , "devicetree@vger.kernel.org" , linux-samsung-soc , Arnd Bergmann , Ian Campbell , Tomasz Figa , Grant Likely , Rob Herring , Olof Johansson , linux-arm-kernel On 02/25/14 09:52, Tomasz Figa wrote: > On 25.02.2014 01:35, Kukjin Kim wrote: [...] >> Well, let me see common.c and mach-exynos.c, one is for SoC specific >> stuff and the other is for Board specific so I think, keeping current >> file would be good, we can change the file name mach-exynos.c or >> board-exynos.c though. > > There is no board specific stuff in mach-exynos/ with DT, so there is no > need to keep those file separate, especially when stuff from common.c is > constantly being (re)moved. > OK. > Also I'd rather stick to what other platforms use, which would be > exynos.c (like tegra.c), as Arnd proposed. > agreed. OK. - Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Tue, 25 Feb 2014 10:00:49 +0900 Subject: [PATCH 1/1] ARM: Exynos: Add generic compatible string In-Reply-To: <530BE93F.2070904@gmail.com> References: <1392809645-631-1-git-send-email-sachin.kamat@linaro.org> <53075239.4010603@samsung.com> <2200834.G3JJLYQl5i@wuerfel> <53076F00.7000001@samsung.com> <53077160.5030202@samsung.com> <530BE557.20106@samsung.com> <530BE93F.2070904@gmail.com> Message-ID: <530BEB41.5070107@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/25/14 09:52, Tomasz Figa wrote: > On 25.02.2014 01:35, Kukjin Kim wrote: [...] >> Well, let me see common.c and mach-exynos.c, one is for SoC specific >> stuff and the other is for Board specific so I think, keeping current >> file would be good, we can change the file name mach-exynos.c or >> board-exynos.c though. > > There is no board specific stuff in mach-exynos/ with DT, so there is no > need to keep those file separate, especially when stuff from common.c is > constantly being (re)moved. > OK. > Also I'd rather stick to what other platforms use, which would be > exynos.c (like tegra.c), as Arnd proposed. > agreed. OK. - Kukjin