From: Prarit Bhargava <prarit@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "nhorman@redhat.com" <nhorman@redhat.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Bruce Allan <bruce.w.allan@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"agospoda@redhat.com" <agospoda@redhat.com>,
John Ronciak <john.ronciak@intel.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 0/2] ixgbe, fix numa issues
Date: Tue, 25 Feb 2014 06:00:46 -0500 [thread overview]
Message-ID: <530C77DE.8050409@redhat.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6CA75F@AcuExch.aculab.com>
On 02/25/2014 05:21 AM, David Laight wrote:
> From: Prarit Bhargava
> ...
>> What has caused that check to be necessary is that the ixgbe driver is now
>> allocating so many interrupts that on large systems which full sockets are taken
>> in and out of service, it is possible that there are not enough empty vectors
>> for all the irqs on a down'd cpu. IMO what the ixgbe driver is effectively
>> doing is starving the system of resources. If I rmmod the ixgbe driver (and
>> free it's irqs of course) I have no problem in taking all cpus except 1 out of
>> service.
>
> If I read that correctly it looks as though ixgbe should be allocating
> a number of interrupts on each cpu - for the interrupts it wants to take
> on that cpu.
Yes, the code currently does it.
>
> Then taking the cpu out of service would 'just' require that the interrupts
> that are tied to that cpu be removed first?
Yes, that would happen with a cpu notifier (I've already written a simple dummy
one that just printk's when called). I started to implement a single queue
teardown but hit some of these enumeration issues. I'd like to fix these first
and then get to the teardown.
P.
>
> David
>
>
>
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2014-02-25 11:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 18:51 [PATCH 0/2] ixgbe, fix numa issues Prarit Bhargava
2014-02-24 18:51 ` [PATCH 1/2] ixgbe, make interrupt allocations NUMA aware Prarit Bhargava
2014-02-24 19:26 ` Alexander Duyck
2014-02-24 19:39 ` Prarit Bhargava
2014-02-24 19:49 ` Alexander Duyck
2014-02-24 18:51 ` [PATCH 2/2] ixgbe, don't assume mapping of numa node cpus Prarit Bhargava
2014-02-24 19:39 ` Alexander Duyck
2014-02-25 17:27 ` Amir Vadai
2014-02-25 17:43 ` Prarit Bhargava
2014-02-24 19:23 ` [PATCH 0/2] ixgbe, fix numa issues Alexander Duyck
2014-02-24 19:34 ` Prarit Bhargava
2014-02-24 19:57 ` Alexander Duyck
2014-02-25 1:06 ` Prarit Bhargava
2014-02-25 10:21 ` David Laight
2014-02-25 11:00 ` Prarit Bhargava [this message]
2014-02-25 15:10 ` Alexander Duyck
2014-02-25 15:13 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530C77DE.8050409@redhat.com \
--to=prarit@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=agospoda@redhat.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.