All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra.
Date: Tue, 25 Feb 2014 17:59:40 +0100	[thread overview]
Message-ID: <530CCBFC.6070603@mind.be> (raw)
In-Reply-To: <1393233942-11638-2-git-send-email-eric.le.bihan.dev@free.fr>

On 24/02/14 10:25, Eric Le Bihan wrote:
> The udev virtual package and its current providers (eudev and systemd)
> have been updated to use the latest version of virtual package
> infrastructure.
> 
> A provider should now select BR2_PACKAGE_HAS_UDEV and well as set a
> value for BR2_PACKAGE_PROVIDES_UDEV.
> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> ---
>  package/eudev/Config.in   |    3 +++
>  package/systemd/Config.in |    3 +++
>  package/udev/Config.in    |    8 ++++----
>  package/udev/udev.mk      |   16 ++++------------
>  4 files changed, 14 insertions(+), 16 deletions(-)
> 
> diff --git a/package/eudev/Config.in b/package/eudev/Config.in
> index bfad99a..40ff721 100644
> --- a/package/eudev/Config.in
> +++ b/package/eudev/Config.in
> @@ -21,6 +21,9 @@ config BR2_PACKAGE_EUDEV
>  
>  if BR2_PACKAGE_EUDEV
>  
> +config BR2_PACKAGE_PROVIDES_UDEV
> +	default "eudev"
> +
>  config BR2_PACKAGE_EUDEV_RULES_GEN
>  	bool "enable rules generator"
>  	help
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index e3ea433..eacc23c 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -40,6 +40,9 @@ config BR2_PACKAGE_SYSTEMD
>  
>  if BR2_PACKAGE_SYSTEMD
>  
> +config BR2_PACKAGE_PROVIDES_UDEV
> +	default "systemd"
> +
>  config BR2_PACKAGE_SYSTEMD_ALL_EXTRAS
>  	bool "enable all extras"
>  	select BR2_PACKAGE_XZ
> diff --git a/package/udev/Config.in b/package/udev/Config.in
> index 5cd4051..941a515 100644
> --- a/package/udev/Config.in
> +++ b/package/udev/Config.in
> @@ -1,6 +1,6 @@
>  config BR2_PACKAGE_HAS_UDEV
>  	bool
> -	help
> -	  udev is now a virtual package.
> -	  Packages requiring udevd at run time or libudev/gudev at build time
> -	  should select it.
> +
> +config BR2_PACKAGE_PROVIDES_UDEV
> +	depends on BR2_PACKAGE_HAS_UDEV
> +	string
> diff --git a/package/udev/udev.mk b/package/udev/udev.mk
> index a5d0f80..f5eeeb4 100644
> --- a/package/udev/udev.mk
> +++ b/package/udev/udev.mk
> @@ -5,20 +5,12 @@
>  ################################################################################
>  
>  UDEV_SOURCE =
> +UDEV_DEPENDENCIES = $(call qstrip,$(BR2_PACKAGE_PROVIDES_UDEV))
>  
> -ifeq ($(BR2_PACKAGE_EUDEV),y)
> -UDEV_DEPENDENCIES += eudev
> -endif
> -
> -ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> -UDEV_DEPENDENCIES += systemd
> -endif
> -
> +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
>  ifeq ($(UDEV_DEPENDENCIES),)
> -define UDEV_CONFIGURE_CMDS
> -	echo "No Udev implementation selected. Configuration error."
> -	exit 1
> -endef
> +$(error No Udev implementation selected. Configuration error)
> +endif
>  endif
>  
>  $(eval $(generic-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-02-25 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  9:25 [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Eric Le Bihan
2014-02-24  9:25 ` [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra Eric Le Bihan
2014-02-25 16:59   ` Arnout Vandecappelle [this message]
2014-02-25 20:28     ` Samuel Martin
2014-02-24  9:25 ` [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features Eric Le Bihan
2014-02-25 17:04   ` Arnout Vandecappelle
2014-02-25 20:32     ` Samuel Martin
2014-02-25 20:29 ` [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530CCBFC.6070603@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.