From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIMiX-0004zF-Ut for qemu-devel@nongnu.org; Tue, 25 Feb 2014 13:27:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIMiQ-0002qF-L0 for qemu-devel@nongnu.org; Tue, 25 Feb 2014 13:26:57 -0500 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:33887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIMiQ-0002q7-EP for qemu-devel@nongnu.org; Tue, 25 Feb 2014 13:26:50 -0500 Message-ID: <530CE05D.50209@weilnetz.de> Date: Tue, 25 Feb 2014 19:26:37 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1393268897-13907-1-git-send-email-romain@dolbeau.org> <530C4DC0.6000506@suse.de> In-Reply-To: <530C4DC0.6000506@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Drop legacy device lists? (was: [PATCH] e1000: add the ability to select among several specific types of e1000 ...) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Romain Dolbeau , qemu-devel@nongnu.org Cc: Stefan Hajnoczi Am 25.02.2014 09:01, schrieb Andreas F=E4rber: > Hi, > > Am 24.02.2014 20:08, schrieb Romain Dolbeau: [...] >> diff --git a/hw/pci/pci.c b/hw/pci/pci.c >> index 4e0701d..07c8cdd 100644 >> --- a/hw/pci/pci.c >> +++ b/hw/pci/pci.c >> @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] =3D { >> "i82559er", >> "rtl8139", >> "e1000", >> + "82540EM", >> + "82544GC", >> + "82545EM", >> "pcnet", >> "virtio", >> NULL >> @@ -1584,6 +1587,9 @@ static const char * const pci_nic_names[] =3D { >> "i82559er", >> "rtl8139", >> "e1000", >> + "82540EM", >> + "82544GC", >> + "82545EM", >> "pcnet", >> "virtio-net-pci", >> NULL > I would hope that adding to these two legacy lists is not necessary for > new types. They should be created using -device, not -net nic,model=3D. > > Regards, > Andreas What about removing those lists for QEMU 2.0? We should use the version update to get rid of some legacy interfaces. Stefan