From: Srinivas Eeda <srinivas.eeda@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 5/6] ocfs2: Avoid blocking in ocfs2_mark_lockres_freeing() in downconvert thread
Date: Tue, 25 Feb 2014 12:03:43 -0800 [thread overview]
Message-ID: <530CF71F.7080304@oracle.com> (raw)
In-Reply-To: <20140225191257.GJ5716@wotan.suse.de>
On 02/25/2014 11:12 AM, Mark Fasheh wrote:
> On Fri, Feb 21, 2014 at 10:45:03AM +0100, Jan Kara wrote:
>> If we are dropping last inode reference from downconvert thread, we will
>> end up calling ocfs2_mark_lockres_freeing() which can block if the lock
>> we are freeing is queued thus creating an A-A deadlock. Luckily, since
>> we are the downconvert thread, we can immediately dequeue the lock and
>> thus avoid waiting in this case.
>>
>> Signed-off-by: Jan Kara <jack@suse.cz>
> Latest version of this looks good, thanks Jan!
>
> Reviewed-by: Mark Fasheh <mfasheh@suse.de>
> --Mark
I didn't sent my reviewed by as akpm already queued this patch. But yes
the new version looks good to me.
Reviewed-by: Srinivas Eeda<srinivas.eeda@oracle.com>
> --
> Mark Fasheh
next prev parent reply other threads:[~2014-02-25 20:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 9:44 [Ocfs2-devel] [PATCH 0/6 v3] ocfs2: Avoid pending orphaned inodes Jan Kara
2014-02-21 9:44 ` [Ocfs2-devel] [PATCH 1/6] ocfs2: Remove OCFS2_INODE_SKIP_DELETE flag Jan Kara
2014-02-25 0:07 ` Mark Fasheh
2014-02-21 9:45 ` [Ocfs2-devel] [PATCH 2/6] ocfs2: Move dquot_initialize() in ocfs2_delete_inode() somewhat later Jan Kara
2014-02-25 0:07 ` Mark Fasheh
2014-02-21 9:45 ` [Ocfs2-devel] [PATCH 3/6] quota: Provide function to grab quota structure reference Jan Kara
2014-02-25 18:58 ` Mark Fasheh
2014-02-21 9:45 ` [Ocfs2-devel] [PATCH 4/6] ocfs2: Implement delayed dropping of last dquot reference Jan Kara
2014-02-25 19:01 ` Mark Fasheh
2014-02-21 9:45 ` [Ocfs2-devel] [PATCH 5/6] ocfs2: Avoid blocking in ocfs2_mark_lockres_freeing() in downconvert thread Jan Kara
2014-02-25 19:12 ` Mark Fasheh
2014-02-25 20:03 ` Srinivas Eeda [this message]
2014-02-21 9:45 ` [Ocfs2-devel] [PATCH 6/6] ocfs2: Revert iput deferring code in ocfs2_drop_dentry_lock Jan Kara
2014-02-25 20:02 ` Mark Fasheh
2014-02-25 21:18 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2014-02-26 16:49 [Ocfs2-devel] [PATCH 0/6 v5] ocfs2: Avoid pending orphaned inodes Jan Kara
2014-02-26 16:49 ` [Ocfs2-devel] [PATCH 5/6] ocfs2: Avoid blocking in ocfs2_mark_lockres_freeing() in downconvert thread Jan Kara
2014-02-26 11:05 [Ocfs2-devel] [PATCH 0/6 v4] ocfs2: Avoid pending orphaned inodes Jan Kara
2014-02-26 11:05 ` [Ocfs2-devel] [PATCH 5/6] ocfs2: Avoid blocking in ocfs2_mark_lockres_freeing() in downconvert thread Jan Kara
2014-02-20 15:18 [Ocfs2-devel] [PATCH 0/6 v2] ocfs2: Avoid pending orphaned inodes Jan Kara
2014-02-20 15:18 ` [Ocfs2-devel] [PATCH 5/6] ocfs2: Avoid blocking in ocfs2_mark_lockres_freeing() in downconvert thread Jan Kara
2014-02-21 5:21 ` Srinivas Eeda
2014-02-21 9:14 ` Jan Kara
2014-02-21 9:35 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530CF71F.7080304@oracle.com \
--to=srinivas.eeda@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.