From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Olof Johansson <olof@lixom.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Wang Dongsheng <dongsheng.wang@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: warn users of smt-snooze-delay that the API isn't there anymore
Date: Tue, 25 Feb 2014 14:47:11 -0800 [thread overview]
Message-ID: <530D1D6F.1050603@linux.vnet.ibm.com> (raw)
In-Reply-To: <530C21E6.5020106@linux.vnet.ibm.com>
On 02/24/2014 08:53 PM, Madhavan Srinivasan wrote:
> On Saturday 22 February 2014 05:44 AM, Cody P Schafer wrote:
>> /sys/devices/system/cpu/cpu*/smt-snooze-delay was converted into a NOP
>> in commit 3fa8cad82b94d0bed002571bd246f2299ffc876b, and now does
>> nothing. Add a pr_warn() to convince any users that they should stop
>> using it.
>>
>> The commit message from the removing commit notes that this
>> functionality should move into the cpuidle driver, essentially by
>
> Would prefer to cleanup the code since the functionality is moved,
> instead of adding to it.
We'd still want users of the interface to use an attribute wired up
under the cpuidle/ dir, so a warning (to update their software) is still
needed. As deepthi has noted, cpuidle right now doesn't support changing
this on a per-cpu basis, so a "cleanup" isn't a simple matter.
WARNING: multiple messages have this Message-ID (diff)
From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Olof Johansson <olof@lixom.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Wang Dongsheng <dongsheng.wang@freescale.com>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: warn users of smt-snooze-delay that the API isn't there anymore
Date: Tue, 25 Feb 2014 14:47:11 -0800 [thread overview]
Message-ID: <530D1D6F.1050603@linux.vnet.ibm.com> (raw)
In-Reply-To: <530C21E6.5020106@linux.vnet.ibm.com>
On 02/24/2014 08:53 PM, Madhavan Srinivasan wrote:
> On Saturday 22 February 2014 05:44 AM, Cody P Schafer wrote:
>> /sys/devices/system/cpu/cpu*/smt-snooze-delay was converted into a NOP
>> in commit 3fa8cad82b94d0bed002571bd246f2299ffc876b, and now does
>> nothing. Add a pr_warn() to convince any users that they should stop
>> using it.
>>
>> The commit message from the removing commit notes that this
>> functionality should move into the cpuidle driver, essentially by
>
> Would prefer to cleanup the code since the functionality is moved,
> instead of adding to it.
We'd still want users of the interface to use an attribute wired up
under the cpuidle/ dir, so a warning (to update their software) is still
needed. As deepthi has noted, cpuidle right now doesn't support changing
this on a per-cpu basis, so a "cleanup" isn't a simple matter.
next prev parent reply other threads:[~2014-02-25 22:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 0:14 [PATCH] powerpc: warn users of smt-snooze-delay that the API isn't there anymore Cody P Schafer
2014-02-22 0:14 ` Cody P Schafer
2014-02-25 4:53 ` Madhavan Srinivasan
2014-02-25 4:53 ` Madhavan Srinivasan
2014-02-25 22:47 ` Cody P Schafer [this message]
2014-02-25 22:47 ` Cody P Schafer
2014-02-25 7:59 ` Deepthi Dharwar
2014-02-25 7:59 ` Deepthi Dharwar
2014-02-25 22:40 ` Benjamin Herrenschmidt
2014-02-25 22:40 ` Benjamin Herrenschmidt
2014-02-26 3:45 ` Michael Ellerman
2014-02-26 3:45 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530D1D6F.1050603@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dongsheng.wang@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.