From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH V8 RESEND] ns16550: Add support for UART
 present in Broadcom TruManage capable NetXtreme chips
Date: Wed, 26 Feb 2014 07:09:11 +0000
Message-ID: <530D9317.4070600@gmail.com>
References: <1393362687-6530-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1393362687-6530-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Cc: Thomas Lendacky <Thomas.Lendacky@amd.com>, jbeulich@suse.com, andrew.cooper3@citrix.com, xen-devel@lists.xen.org, Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, sherry.hurwitz@amd.com, shurd@broadcom.com
List-Id: xen-devel@lists.xenproject.org

Aravind Gopalakrishnan wrote:
> Since it is an MMIO device, the code has been modified to accept MMIO based
> devices as well. MMIO device settings are populated in the 'uart_config' table.
> It also advertises 64 bit BAR. Therefore, code is reworked to account for 64
> bit BAR and 64 bit MMIO lengths.
>
> Some more quirks are - the need to shift the register offset by a specific
> value and we also need to verify (UART_LSR_THRE&&  UART_LSR_TEMT) bits before
> transmitting data.
>
> While testing, include com1=115200,8n1,pci,0 on the xen cmdline to observe
> output on console using SoL.
>
> Changes from V7:
>    - per Jan's comments:
>      - Moving pci_ro_device to ns16550_init_postirq() so that either
>        one of pci_hide_device or pci_ro_device is done at one place
>      - remove leading '0' from printk as absent segment identifier
>        implies zero anyway.
>    - per Ian's comments:
>      - fixed issues that casued his build to fail.
>      - cross-compiled for arm32 and arm64 after applying patch and
>        build was successful on local machine.
>
> Signed-off-by: Aravind Gopalakrishnan<Aravind.Gopalakrishnan@amd.com>
> Signed-off-by: Suravee Suthikulpanit<Suravee.Suthikulpanit@amd.com>
> Signed-off-by: Thomas Lendacky<Thomas.Lendacky@amd.com>
Acked-by: Keir Fraser <keir@xen.org>