From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device
Date: Wed, 26 Feb 2014 10:07:25 +0100 [thread overview]
Message-ID: <530DAECD.8010405@broadcom.com> (raw)
In-Reply-To: <1393358376.4170.22.camel@jlt4.sipsolutions.net>
On 02/25/2014 08:59 PM, Johannes Berg wrote:
> On Tue, 2014-02-25 at 20:30 +0100, Arend van Spriel wrote:
>> Upon deleting the interface a cfg80211_disconnected() is called under
>> rtnl_lock. Right after the unlocking the rtnl_lock we unregister the
>> network device. This patch adds delay before unregister so cfg80211
>> can handle disconnect and notify wpa_supplicant.
>
>> + /* make sure cfg80211 can send disconnect event
>> + * before unregistering the netdevice below.
>> + */
>> + msleep(100);
>
> This has got to be one of the worst hacks I've seen in wireless so
> far ... :)
Did you see I removed a sleep as well in this patch :-p
I just don't see how I can assure cfg80211 has actually done the
disconnect work. If we don't do a cfg80211_disconnected() I get a WARN
from the cfg80211 netdev notifier (or at least I did in previous kernel).
Should we consider a clean solution, ie. modify cfg80211 for this scenario?
Gr. AvS
next prev parent reply other threads:[~2014-02-26 9:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 19:30 [PATCH 00/14] brcmfmac: driver cleanup and rework Arend van Spriel
2014-02-25 19:30 ` [PATCH 01/14] brcmfmac: add delay before unregistering the network device Arend van Spriel
2014-02-25 19:59 ` Johannes Berg
2014-02-26 9:07 ` Arend van Spriel [this message]
2014-02-26 9:17 ` Johannes Berg
2014-02-26 9:28 ` Arend van Spriel
2014-02-26 9:37 ` Johannes Berg
2014-02-26 10:43 ` Arend van Spriel
2014-02-26 11:10 ` Johannes Berg
2014-02-26 11:34 ` Arend van Spriel
2014-02-26 11:48 ` Johannes Berg
2014-02-26 12:18 ` Arend van Spriel
2014-02-26 12:22 ` Johannes Berg
2014-02-26 12:35 ` Arend van Spriel
2014-02-25 19:30 ` [PATCH 02/14] brcmfmac: Make firmeware roaming a module param Arend van Spriel
2014-02-25 19:30 ` [PATCH 03/14] brcmfmac: fix use of skb control buffer in SDIO driver part Arend van Spriel
2014-02-25 19:30 ` [PATCH 04/14] brcmfmac: remove unused variable data_len from brcmf_sdio_bus_txdata() Arend van Spriel
2014-02-25 19:30 ` [PATCH 05/14] brcmfmac: Correct header debug dump for sdio tx hdrs Arend van Spriel
2014-02-25 19:30 ` [PATCH 06/14] brcmfmac: de-init driver layers in correct order Arend van Spriel
2014-02-25 19:30 ` [PATCH 07/14] brcmfmac: Minimize SDIO dpc scheduling Arend van Spriel
2014-02-25 19:30 ` [PATCH 08/14] brcmfmac: Remove immediate sleep support from SDIO Arend van Spriel
2014-02-25 19:30 ` [PATCH 09/14] brcmfmac: Small cleanup of redundant code Arend van Spriel
2014-02-25 19:30 ` [PATCH 10/14] brcmfmac: Use atomic functions for intstatus update Arend van Spriel
2014-02-25 23:38 ` Florian Fainelli
2014-02-26 12:20 ` Arend van Spriel
2014-02-25 19:30 ` [PATCH 11/14] brcmfmac: Put frame sdio tx error handling in sub function Arend van Spriel
2014-02-25 19:30 ` [PATCH 12/14] brcmfmac: Correct mcs index report Arend van Spriel
2014-02-25 19:30 ` [PATCH 13/14] brcmfmac: use pre-allocated scatter-gather table for txglomming Arend van Spriel
2014-02-25 19:30 ` [PATCH 14/14] brcmfmac: reset suspend flag upon sdio suspend failure Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530DAECD.8010405@broadcom.com \
--to=arend@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.