From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [uq/master PATCH] kvm-all: exit in case max vcpus exceeded
Date: Wed, 26 Feb 2014 11:27:44 +0100 [thread overview]
Message-ID: <530DC1A0.80703@redhat.com> (raw)
In-Reply-To: <20140226022207.GA2787@amt.cnet>
Il 26/02/2014 03:22, Marcelo Tosatti ha scritto:
>
> Rather than fall back to TCG (so the user has to discover
> whats happening, in case of no access to qemu stdout/stderr).
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 3937754..3f6841d 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1432,11 +1432,10 @@ int kvm_init(void)
> nc->name, nc->num, soft_vcpus_limit);
>
> if (nc->num > hard_vcpus_limit) {
> - ret = -EINVAL;
> fprintf(stderr, "Number of %s cpus requested (%d) exceeds "
> "the maximum cpus supported by KVM (%d)\n",
> nc->name, nc->num, hard_vcpus_limit);
> - goto err;
> + exit(1);
> }
> }
> nc++;
>
Thanks, I applied this locally. I'll push to uq/master once the pending
pull request is processed.
Paolo
prev parent reply other threads:[~2014-02-26 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 2:22 [uq/master PATCH] kvm-all: exit in case max vcpus exceeded Marcelo Tosatti
2014-02-26 10:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530DC1A0.80703@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.