From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43018)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WIbos-0007l3-Pn
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 05:34:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WIbom-00051F-Qy
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 05:34:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WIbom-00051A-Gf
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 05:34:24 -0500
Message-ID: <530DC326.7020806@redhat.com>
Date: Wed, 26 Feb 2014 11:34:14 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393406718-16860-1-git-send-email-xbing6@gmail.com>
	<CAFEAcA-D5ciZVWZaBkf7YB_DmtgyxvraKTG=DTEXiUgtbeEQUA@mail.gmail.com>
In-Reply-To: <CAFEAcA-D5ciZVWZaBkf7YB_DmtgyxvraKTG=DTEXiUgtbeEQUA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] translate: remove file translate-all.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Xuebing Wang <xbing6@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Il 26/02/2014 10:55, Peter Maydell ha scritto:
> On 26 February 2014 09:25, Xuebing Wang <xbing6@gmail.com> wrote:
>> This patch does below:
>> -   Move the declaration of 2 translate functions from translate-all.h into
>>     include/exec/exec-all.h
>> -   remove file translate-all.h
>>
>> "translate-all.h" => "exec/exec-all.h" can be done by:
>> git grep -w "translate-all.h" | cut -d: -f1 |
>>     xargs sed -i 's/\<translate-all.h\>/exec\/exec-all.h/g'
>>
>> Note:
>> 1)  "exact whole word match" is considered.
>> 2)  We may move translate related from include/exec/exec-all.h into
>>     include/exec/translate.h later.
>
> Is there any particular benefit to this change? The function
> prototypes go from being in a header only included by the file
> that uses them to being in a header that's included by a lot
> of other code...

Indeed, that's the point of translate-all.h.

Paolo