Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts

[Paolo Bonzini <pbonzini@redhat.com>]

Il 26/02/2014 14:42, Laszlo Ersek ha scritto:
> When you have a QemuOpt that takes an argument, then the documentation
> of the default behavior usually explains the case when the QemuOpt is
> present, and the argument is absent. The documentation of the default
> behavior usually doesn't concern the case when the QemuOpt*s* itself is
> absent. Cf.
>
> (1) -foo bar
> (2) -foo bar=baz
> (3) [nothing]
>
> The "default" in the docs tends to explain case (1), not case (3).
>
> In this case we have: -m [mem=]megs
>
> (1) -m mem -- makes no sense
> (2) -m mem=megs -- works, and well documented
> (3) [nothing] -- is what the proposed docs describe as "default", but it
> doesn't match "historical practice".
>
> (1) in general can make sense, eg. for booleans.
>
> Anyway I don't feel strongly about this in the least -- I just thought
> I'd point it out.

Yeah, you're right.

> Feel free to ignore it; I have no good suggestion as
> to how to make it consistent across all options.

Neither do I, but at least "megs" is not marked as an optional element, 
so I think it's not that ambiguous.

Paolo