From: Richard Weinberger <richard@nod.at>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm,renesas-tpu: Add dependency on HAS_IOMEM
Date: Wed, 26 Feb 2014 15:06:31 +0100 [thread overview]
Message-ID: <530DF4E7.1060900@nod.at> (raw)
In-Reply-To: <20140226120800.GA28939@ulmo.nvidia.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am 26.02.2014 13:08, schrieb Thierry Reding:
> On Fri, Jan 31, 2014 at 01:45:18PM +0100, Richard Weinberger wrote:
>> On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures.
>>
>> drivers/built-in.o: In function `tpu_probe': drivers/pwm/pwm-renesas-tpu.c:421: undefined reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/pwm/Kconfig | 1 + 1 file changed, 1 insertion(+)
>
> In the long run I think it might be better to add a dummy implementation for devm_ioremap_resource() in order to make it build properly even for architectures where it isn't
> implemented.
And what should devm_ioremap_resource() or in general ioremap() do on archs without
iomem?
BUG()? Returning a random error and hoping that the driver handles it correctly? :)
IMHO such a dummy implementation does not make much sense.
> For now this looks like the best option. Applied, thanks.
Thanks!
//richard
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJTDfTnAAoJEPmeIjfg4Uaa0hsP/1lgoKuMLbfXEw8Z064st3lk
pOQoQQYiyk9nW5Uj/yjFAq9hly+jtL6YdY9+i2q9aQAaIOqTj0I0VbmMy+1nFrdF
x7ahD1Z4BAI0PSTj3P8LaYs6Jn+zaok2Zo7B6BlJIvLlNZqqvgQHcCVWHK5srdHu
sjd6JwpvBykWSmNUMBG2oAkWCTKLjisXTIL1OsIbcyTgBSS7/17dHfaFqhgZJBTI
L3aHRQYOTEdXJyCRZq4SUwNSBXUdP2AmaDJZ4HQ17nuXUTOTnAMgpVUgidgLasmF
GAmSDunoi/i7Pu6Vu+562cZhmuzO+uYFo87hDivjn7tTPIJ0OMh4pHeWWaMWVye/
o9GYI1Ew86Lbekd5Xxhf32hNnhz5RxZlNrnjdO1y2GNW5bt7A5ukF4jY0QEuHC+q
tgLsS45NIECkqA2hk7nvgRdds1ZaqueuY1dw8mb2jIbuAuR3XXSfjVzdfQiXKxzA
tXugXynMSP93mHEeOwzc1pRnFl6j1KgbNOMX9MuYwc5corUShab/Z1d+RVWNat7c
iTn6b/GxWpPeMQv3qXvIe77R2UnFv50M2KW4RXs2MRZdXCbIR2FLojGl0fTp1lNo
7mTnB/8SnJBbHz5+1tQv2exFfmalNhM78RighfONJcTnmXfvmA20aNo9Kn3IEU0t
m2V40kQySnkcb7+gRXrR
=34dU
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-02-26 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 12:45 [PATCH] pwm,renesas-tpu: Add dependency on HAS_IOMEM Richard Weinberger
2014-02-26 11:59 ` Richard Weinberger
2014-02-26 12:08 ` Thierry Reding
2014-02-26 14:06 ` Richard Weinberger [this message]
2014-02-26 14:12 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530DF4E7.1060900@nod.at \
--to=richard@nod.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.