From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com (zimbra.linbit.com [212.69.161.123]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 652C4101AC77 for ; Wed, 26 Feb 2014 17:24:07 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id 2896B32174F for ; Wed, 26 Feb 2014 17:24:06 +0100 (CET) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id yEKsQaZFVStE for ; Wed, 26 Feb 2014 17:24:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra13.linbit.com (Postfix) with ESMTP id DE2CC321753 for ; Wed, 26 Feb 2014 17:24:05 +0100 (CET) Received: from zimbra13.linbit.com ([127.0.0.1]) by localhost (zimbra13.linbit.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sQieXkvjOiUa for ; Wed, 26 Feb 2014 17:24:05 +0100 (CET) Received: from soda.linbit (tuerlsteher.linbit.com [86.59.100.100]) by zimbra13.linbit.com (Postfix) with ESMTPS id 8A83E32174F for ; Wed, 26 Feb 2014 17:24:05 +0100 (CET) Resent-Message-ID: <20140226162405.GD3154@soda.linbit> Message-ID: <530E05DA.6070500@citrix.com> Date: Wed, 26 Feb 2014 16:18:50 +0100 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= MIME-Version: 1.0 To: References: <1392911976-37506-1-git-send-email-roger.pau@citrix.com> In-Reply-To: <1392911976-37506-1-git-send-email-roger.pau@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: xen-devel@lists.xenproject.org, drbd-user@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH] block-drbd: type is "phy" for drbd backends List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , I've realized I haven't Cc'ed the drbd developers lists, so adding it now= . On 20/02/14 16:59, Roger Pau Monne wrote: > The type written to xenstore by libxl when attaching a drbd backend is > "phy", not "drbd", so handle this case also. >=20 > Signed-off-by: Roger Pau Monn=C3=A9 > --- > scripts/block-drbd | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/scripts/block-drbd b/scripts/block-drbd > index 5563ccb..975802b 100755 > --- a/scripts/block-drbd > +++ b/scripts/block-drbd > @@ -250,7 +250,7 @@ case "$command" in > fi > =20 > case $t in=20 > - drbd) > + drbd|phy) > drbd_resource=3D$p > drbd_role=3D"$(drbdadm role $drbd_resource)" > drbd_lrole=3D"${drbd_role%%/*}" > @@ -278,7 +278,7 @@ case "$command" in > =20 > remove) > case $t in=20 > - drbd) > + drbd|phy) > p=3D$(xenstore_read "$XENBUS_PATH/params") > drbd_resource=3D$p > drbd_role=3D"$(drbdadm role $drbd_resource)" >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH] block-drbd: type is "phy" for drbd backends Date: Wed, 26 Feb 2014 16:18:50 +0100 Message-ID: <530E05DA.6070500@citrix.com> References: <1392911976-37506-1-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WIgG7-000230-0h for xen-devel@lists.xenproject.org; Wed, 26 Feb 2014 15:18:55 +0000 In-Reply-To: <1392911976-37506-1-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: drbd-dev@lists.linbit.com Cc: xen-devel@lists.xenproject.org, drbd-user@lists.linbit.com List-Id: xen-devel@lists.xenproject.org CkkndmUgcmVhbGl6ZWQgSSBoYXZlbid0IENjJ2VkIHRoZSBkcmJkIGRldmVsb3BlcnMgbGlzdHMs IHNvIGFkZGluZyBpdCBub3cuCgpPbiAyMC8wMi8xNCAxNjo1OSwgUm9nZXIgUGF1IE1vbm5lIHdy b3RlOgo+IFRoZSB0eXBlIHdyaXR0ZW4gdG8geGVuc3RvcmUgYnkgbGlieGwgd2hlbiBhdHRhY2hp bmcgYSBkcmJkIGJhY2tlbmQgaXMKPiAicGh5Iiwgbm90ICJkcmJkIiwgc28gaGFuZGxlIHRoaXMg Y2FzZSBhbHNvLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBh dUBjaXRyaXguY29tPgo+IC0tLQo+ICBzY3JpcHRzL2Jsb2NrLWRyYmQgfCAgICA0ICsrLS0KPiAg MSBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL3NjcmlwdHMvYmxvY2stZHJiZCBiL3NjcmlwdHMvYmxvY2stZHJiZAo+IGluZGV4 IDU1NjNjY2IuLjk3NTgwMmIgMTAwNzU1Cj4gLS0tIGEvc2NyaXB0cy9ibG9jay1kcmJkCj4gKysr IGIvc2NyaXB0cy9ibG9jay1kcmJkCj4gQEAgLTI1MCw3ICsyNTAsNyBAQCBjYXNlICIkY29tbWFu ZCIgaW4KPiAgICAgIGZpCj4gIAo+ICAgICAgY2FzZSAkdCBpbiAKPiAtICAgICAgZHJiZCkKPiAr ICAgICAgZHJiZHxwaHkpCj4gICAgICAgICAgZHJiZF9yZXNvdXJjZT0kcAo+ICAgICAgICAgIGRy YmRfcm9sZT0iJChkcmJkYWRtIHJvbGUgJGRyYmRfcmVzb3VyY2UpIgo+ICAgICAgICAgIGRyYmRf bHJvbGU9IiR7ZHJiZF9yb2xlJSUvKn0iCj4gQEAgLTI3OCw3ICsyNzgsNyBAQCBjYXNlICIkY29t bWFuZCIgaW4KPiAgCj4gICAgcmVtb3ZlKQo+ICAgICAgY2FzZSAkdCBpbiAKPiAtICAgICAgZHJi ZCkKPiArICAgICAgZHJiZHxwaHkpCj4gICAgICAgICAgcD0kKHhlbnN0b3JlX3JlYWQgIiRYRU5C VVNfUEFUSC9wYXJhbXMiKQo+ICAgICAgICAgIGRyYmRfcmVzb3VyY2U9JHAKPiAgICAgICAgICBk cmJkX3JvbGU9IiQoZHJiZGFkbSByb2xlICRkcmJkX3Jlc291cmNlKSIKPiAKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZl bAo=