All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] vlc: fix some configure options
Date: Wed, 26 Feb 2014 18:49:19 +0100	[thread overview]
Message-ID: <530E291F.2000708@mind.be> (raw)
In-Reply-To: <CAHt8ZCMj+vSa4htd5Q=mbAG=VZq=fpt1s0ubQFP2u4rYQ0FFhA@mail.gmail.com>

On 26/02/14 11:11, Simon Dawson wrote:
> Hi Peter,
> 
> On 25 February 2014 23:00, Peter Korsgaard <peter@korsgaard.com> wrote:
>>  > Did you test these?
> 
> Yes, I did.
> 
>> Ahh, now I get it. Our autoreconf somehow converts all those --enable /
>> --disable to --with / --without.
> 
> Yes, exactly so.
> 
>> Anybody that has any idea why this is so? It quite unfortunate as we
>> will have to change all of this back once we bump the vlc version and no
>> longer need VLC_AUTORECONF = YES.
> 
> I haven't yet got to the bottom of how/why this is happening, I'm afraid.

 There's a lot of strangeness caused by our AUTORECONF...

 I guess it has something to do with all the warnings we get when
AUTORECONFing, since in m4/with_pkg.m4 I do see:

m4_case(def_arg,
            [yes],[m4_pushdef([with_without], [--disable-]with_arg)],
            [m4_pushdef([with_without],[--enable-]with_arg)])

AC_ARG_ENABLE(with_arg,
     AS_HELP_STRING(with_without, description[ @<:@default=]def_arg[@:>@]),,
    [AS_TR_SH([enable_]with_arg)=def_arg])


 In other words, it registers an --enable option.

 I guess that the PKG_CHECK_MODULES option implicitly enables a
--with-foo option as well, but doesn't mention it in the help text.


 Regards,
 Arnout

> 
> Simon.
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-02-26 17:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25 20:36 [Buildroot] [PATCH] vlc: fix some configure options Simon Dawson
2014-02-25 21:50 ` Samuel Martin
2014-02-25 21:55   ` Peter Korsgaard
2014-02-25 21:59     ` Simon Dawson
2014-02-25 22:51 ` Peter Korsgaard
2014-02-25 23:00   ` Peter Korsgaard
2014-02-26 10:11     ` Simon Dawson
2014-02-26 17:49       ` Arnout Vandecappelle [this message]
2014-02-26 23:55     ` Arnout Vandecappelle
2014-02-27 14:40 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530E291F.2000708@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.