From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172] helo=ns3.lanforge.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WIie0-0000mg-J1 for ath10k@lists.infradead.org; Wed, 26 Feb 2014 17:51:45 +0000 Message-ID: <530E2999.6000901@candelatech.com> Date: Wed, 26 Feb 2014 09:51:21 -0800 From: Ben Greear MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX. References: <1392742567-6134-1-git-send-email-greearb@candelatech.com> <87r46plt07.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87r46plt07.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On 02/26/2014 08:48 AM, Kalle Valo wrote: > greearb@candelatech.com writes: > >> From: Ben Greear >> >> This appears to fix the problem of running out of keys >> in the firmware. Possibly it only hides the problem, >> however. >> >> Signed-off-by: Ben Greear > > IIRC you asked me to drop this patch in other thread. I have now done > that. Yes, it breaks upstream firmware (looks like it asserts, but not sure exactly why). I still think it might be a problem, but it would take someone with newer firmware source and/or better understanding of how the keys are supposed to work to know for sure. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.candelatech.com ([208.74.158.172]:41326 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbaBZRvr (ORCPT ); Wed, 26 Feb 2014 12:51:47 -0500 Message-ID: <530E2999.6000901@candelatech.com> (sfid-20140226_185154_830014_15ECC707) Date: Wed, 26 Feb 2014 09:51:21 -0800 From: Ben Greear MIME-Version: 1.0 To: Kalle Valo CC: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX. References: <1392742567-6134-1-git-send-email-greearb@candelatech.com> <87r46plt07.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87r46plt07.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 02/26/2014 08:48 AM, Kalle Valo wrote: > greearb@candelatech.com writes: > >> From: Ben Greear >> >> This appears to fix the problem of running out of keys >> in the firmware. Possibly it only hides the problem, >> however. >> >> Signed-off-by: Ben Greear > > IIRC you asked me to drop this patch in other thread. I have now done > that. Yes, it breaks upstream firmware (looks like it asserts, but not sure exactly why). I still think it might be a problem, but it would take someone with newer firmware source and/or better understanding of how the keys are supposed to work to know for sure. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com