From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH-4.5 v3 01/12] xen/arm: no need to set HCR_VI when using the vgic to inject irqs Date: Wed, 26 Feb 2014 19:50:28 +0000 Message-ID: <530E4584.3080602@linaro.org> References: <1393439997-26936-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393439997-26936-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , xen-devel@lists.xensource.com Cc: jtd@galois.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 26/02/14 18:39, Stefano Stabellini wrote: > It can actually cause spurious interrupt injections into the guest. > I would explain what is the current behaviour with HCR_VI, e.g. the guest is entering in interrupt mode... By only reading the documentation and your commit message, this patch seems wrong (I know it's not the case ;)). -- Julien Grall