From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: jtd@galois.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH-4.5 v3 10/12] xen/arm: don't protect GICH and lr_queue accesses with gic.lock
Date: Wed, 26 Feb 2014 20:17:01 +0000 [thread overview]
Message-ID: <530E4BBD.4010703@linaro.org> (raw)
In-Reply-To: <1393439997-26936-10-git-send-email-stefano.stabellini@eu.citrix.com>
Hi Stefano,
On 26/02/14 18:39, Stefano Stabellini wrote:
> GICH is banked, protect accesses by disabling interrupts.
> Protect lr_queue accesses with the vgic.lock only.
When the interrupt is an SPI, the lr_queue is shared between every VCPU.
Using only vgic.lock seems wrong to me.
--
Julien Grall
next prev parent reply other threads:[~2014-02-26 20:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 18:39 [PATCH-4.5 v3 0/12] remove maintenance interrupts Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 01/12] xen/arm: no need to set HCR_VI when using the vgic to inject irqs Stefano Stabellini
2014-02-26 19:50 ` Julien Grall
2014-02-26 18:39 ` [PATCH-4.5 v3 02/12] xen/arm: remove unused virtual parameter from vgic_vcpu_inject_irq Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 03/12] xen/arm: support HW interrupts in gic_set_lr Stefano Stabellini
2014-02-26 19:51 ` Julien Grall
2014-02-26 18:39 ` [PATCH-4.5 v3 04/12] xen/arm: do not request maintenance_interrupts Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 05/12] xen/arm: set GICH_HCR_UIE if all the LRs are in use Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 06/12] xen/arm: keep track of the GICH_LR used for the irq in struct pending_irq Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 07/12] xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 08/12] xen/arm: call gic_clear_lrs on entry to the hypervisor Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 09/12] xen/arm: second irq injection while the first irq is still inflight Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 10/12] xen/arm: don't protect GICH and lr_queue accesses with gic.lock Stefano Stabellini
2014-02-26 20:17 ` Julien Grall [this message]
2014-03-18 14:59 ` Stefano Stabellini
2014-03-18 15:20 ` Julien Grall
2014-03-18 18:52 ` Stefano Stabellini
2014-03-18 20:26 ` Julien Grall
2014-03-19 11:30 ` Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 11/12] xen/arm: gic_events_need_delivery and irq priorities Stefano Stabellini
2014-02-26 19:36 ` Stefano Stabellini
2014-02-26 18:39 ` [PATCH-4.5 v3 12/12] xen/arm: print more info in gic_dump_info, keep gic_lr sync'ed Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530E4BBD.4010703@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=jtd@galois.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.